replace tensorboard checks with helper function #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsaunde
approved these changes
Dec 3, 2024
tests/e2e/multigpu/test_eval.py
Outdated
| from transformers.testing_utils import get_torch_dist_unique_port | ||
| from utils.tensorboard_ import check_tensorboard |
There was a problem hiding this comment.
Why is utils sorted as a 3rd party package?
There was a problem hiding this comment.
ah, conflict in utils under axolotl and utils under tests maybe? let me see if I can make that work properly
There was a problem hiding this comment.
moving the helper fn and converting to a relative import seems to make it more obvious now.
3 tasks
djsaunde
pushed a commit
that referenced
this pull request
Dec 16, 2024
* replace tensorboard checks with helper function * move helper function * use relative
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* replace tensorboard checks with helper function * move helper function * use relative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a lot of duplicate code and boilerplate for checking tensorboard log values. This helper function should make it much easier to check values from e2e trainings without a lot of extra code.