System prompt data #224
Merged
System prompt data #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Jun 25, 2023
| @@ -128,9 +132,6 @@ def build_prompt( | |||
| ) -> Generator[str, None, None]: | |||
| yield instruction | |||
|
|
|||
| def get_response(self, output: str) -> str: | |||
| return output.strip() | |||
There was a problem hiding this comment.
Are these get_response removed because they are unused?
Yeah. That was dead code that was copied from alpaca repo. |
winglian
force-pushed
the
system-prompt-data
branch
from
b34a813
to
7b57ed7
Compare
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
…/system-prompt-data System prompt data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for pulling the system prompt from the data files. Useful for some CoT datasets.
Also adds more test coverage