-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2360
base: main
Are you sure you want to change the base?
Update README.md #2360
Conversation
wheel is needed
Hey, what kind of env did you start from? I would think wheel would usually be included. |
ubuntu 22, with venv Linux legion 6.8.0-52-generic #53~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Jan 15 19:18:46 UTC 2 x86_64 x86_64 x86_64 GNU/Linux |
odd, if you're using pip install, I think the pyproject.toml should force it to install wheel ahead of time https://github.com/axolotl-ai-cloud/axolotl/blob/main/pyproject.toml#L2 |
Do you have steps to repro? Did you install torch before installing axolotl? |
README.md
Outdated
@@ -57,6 +57,7 @@ Features: | |||
### Installation | |||
|
|||
```shell | |||
pip3 install wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we adjust this to match our CI?
pip3 install -U packaging setuptools wheel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i started with python -m venv env and wheel wasn't included (ubuntu 22, installed torch and all req per instructions)
Hm, I can't repro this. I got a pod running with pytorch and cuda docker image, created a new venv, and installed torch. When I |
wheel is needed
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)