Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max of 32 dataset processes if not explicit #2403

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

winglian
Copy link
Collaborator

should help with #2395 @NanoCode012

@NanoCode012
Copy link
Collaborator

NanoCode012 commented Mar 11, 2025

The reason I mentioned 32 was because we had (in several places), a max of 64.

num_proc = min(64, self.process_count if self.process_count else os.cpu_count())

num_proc = min(64, process_or_cpu_count)

We should probably consolidate this.

@winglian winglian merged commit f0072f3 into main Mar 11, 2025
11 checks passed
@winglian winglian deleted the dataset-processes-limit-default branch March 11, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants