-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging update: added PID and formatting #276
Logging update: added PID and formatting #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@theobjectivedad would you mind fixing a few things for the linter please? thanks!
|
also, lmk if you want any help with the failing unit tests https://github.com/OpenAccess-AI-Collective/axolotl/actions/runs/5554165505/jobs/10144233892?pr=276 there are checks in the unit tests that check the config validation, so the output messages likely changed (or are now generators it seems). It might be easiest to not use the logging module for the validation sub-module |
Ty @winglian, I'll have some time to take a crack at it this Sunday. I'm planning to use Axolotl for my research projects so I need to have a proper dev environment setup anyway. |
Good morning @winglian, please see my last commit ... everything appears to be passing now locally:
|
…enhancement Logging update: added PID and formatting
Logging update: added PID and formatting
Adding a logging enhancement that adds PID, package name, and line number to each logging message, ex:
Background:
I'm working on potential DeepSpeed + additional logging/visibility updates and find it incredibly useful to see which GPU process and exactly which module path/line number triggered a logging event.