-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XGen info to README and example config #306
Conversation
Can you clarify what you mean by "break"? You could add a logging.warn within the validate_config function if it's bad |
I get the following error:
Checking for this in validate_config could be nice (ideally it might be possible to work around it?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thank you!
Add XGen info to README and example config
I should probably add a note that the tokenizer breaks with the sharegpt prompt format at the moment... maybe a footnote in the README?