update README for updated docker images #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Jul 27, 2023
README.md
Outdated
| @@ -107,7 +106,7 @@ accelerate launch scripts/finetune.py examples/openllama-3b/lora.yml \ | |||
|
|
|||
| 3. Install torch | |||
| ```bash | |||
| pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118 | |||
| pip3 install torch==2.0.1+cu118 --index-url https://download.pytorch.org/whl/cu118 | |||
There was a problem hiding this comment.
Suggested change
| pip3 install torch==2.0.1+cu118 --index-url https://download.pytorch.org/whl/cu118 | |
| pip3 install -U torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118 |
I think you do not need to specify the version of torch as latest is 2.0.1 one. Setting that index url also sets the cuda version. The thing I forgot to add was the -U
There was a problem hiding this comment.
thanks, I've updated it with the -U and removed the explicit version. I'm going to keep the removal of torchvision and torchaudio since those aren't needed I don't think
| - `winglian/axolotl-runpod:main-py3.9-cu118-2.0.0-gptq`: for gptq | ||
| - `winglian/axolotl:dev`: dev branch (not usually up to date) | ||
| - `winglian/axolotl-runpod:main-py3.10-cu118-2.0.1`: for runpod | ||
| - `winglian/axolotl-runpod:main-py3.9-cu118-2.0.1-gptq`: for gptq |
There was a problem hiding this comment.
Is there a reason gptq is 3.9 vs the run pod 3.10?
There was a problem hiding this comment.
I haven't touched gptq in a while, so I'd rather leave it at 3.9 where it is believed to still work, rather than trying to upgrade and introduce another potential issue
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
* update README for updated docker images * update readme from pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.