Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(message): Improve error message for bad format #365

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix(message): Improve error message for bad format #365

merged 1 commit into from
Aug 12, 2023

Conversation

NanoCode012
Copy link
Collaborator

Closes #325

winglian
winglian approved these changes Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@NanoCode012 NanoCode012 merged commit e37d935 into axolotl-ai-cloud:main Aug 12, 2023
3 checks passed
@NanoCode012 NanoCode012 deleted the fix/assert-sharegpt-message branch August 12, 2023 16:16
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
@NanoCode012
Fix(message): Improve error message for bad format (axolotl-ai-cloud#365
1a7e2a0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ShareGPT datasets very strict -- data rows with non-standard role throw AssertionError
2 participants
@NanoCode012 @winglian