update docs for tokenizer_legacy #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should clarify the default is True? |
NanoCode012
approved these changes
Aug 15, 2023
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
* update docs for tokenizer_legacy * add default info
May I ask why you default |
|
@tongyx361 , hey! This was from a year ago. If I recall correctly, it was that the new behavior was not correct/created some issues esp for llama. It's very likely they fixed it and this should be reverted. If you would like, please create a new Issue on this, so we can track this better. |
5 tasks
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* update docs for tokenizer_legacy * add default info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.