Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add torch to requirements #42

Closed
wants to merge 1 commit into from

Conversation

NanoCode012
Copy link
Collaborator

@NanoCode012 NanoCode012 commented May 25, 2023

Error with pip install -e . in new venv due to missing torch.

@winglian
Copy link
Collaborator

torch gets installed in the base docker env, but it definitely should exists in requirements. But I think when pip install runs, it tries to delete the version that's already installed. thoughts?

@NanoCode012
Copy link
Collaborator Author

Hm, when I ran pip install -e . in my docker image. It does not install torch again.

Requirement already satisfied: torch>=1.6.0 in /root/miniconda3/envs/py3.9/lib/python3.9/site-packages (from accelerate) (2.0.0)

@winglian
Copy link
Collaborator

thanks, what about different version of torch? for example we build images with 1.13.1 and 2.0.0
https://github.com/OpenAccess-AI-Collective/axolotl/blob/main/.github/workflows/base.yml#L17-L22

@NanoCode012 NanoCode012 marked this pull request as draft May 25, 2023 16:50
@NanoCode012
Copy link
Collaborator Author

I will build the Dockerfile following your dev image for 1.13.1 from docker hub and let you know.

@NanoCode012
Copy link
Collaborator Author

You're right. It does try to install torch 2.0

@NanoCode012
Copy link
Collaborator Author

NanoCode012 commented May 25, 2023

Shall we update the Readme to require Pytorch installed and add a commented to QuickStart

# pip3 install torch

and requirements?

# torch

@winglian
Copy link
Collaborator

Shall we update the Readme to require Pytorch installed and add a commented to QuickStart

# pip3 install torch

and requirements?

# torch

yeah, I think adding it to the docs is sufficient, something like if torch isn't installed yet...

@winglian
Copy link
Collaborator

what about torch>=1.13.1 ?

@NanoCode012
Copy link
Collaborator Author

NanoCode012 commented May 26, 2023

what about torch>=1.13.1 ?

=> => # Collecting torch>=1.13.1 (from axolotl==0.1)                                                                                                                                                                 
 => => #   Downloading torch-2.0.1-cp39-cp39-manylinux1_x86_64.whl (619.9 MB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants