-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add torch to requirements #42
Conversation
torch gets installed in the base docker env, but it definitely should exists in requirements. But I think when pip install runs, it tries to delete the version that's already installed. thoughts? |
Hm, when I ran
|
thanks, what about different version of torch? for example we build images with 1.13.1 and 2.0.0 |
I will build the Dockerfile following your dev image for 1.13.1 from docker hub and let you know. |
You're right. It does try to install torch 2.0 |
Shall we update the Readme to require Pytorch installed and add a commented to QuickStart # pip3 install torch and requirements? # torch |
yeah, I think adding it to the docs is sufficient, something like |
what about |
=> => # Collecting torch>=1.13.1 (from axolotl==0.1)
=> => # Downloading torch-2.0.1-cp39-cp39-manylinux1_x86_64.whl (619.9 MB) |
Error with
pip install -e .
in new venv due to missing torch.