improve: Enhance code readability of prompt_tokenizers.py #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
As many tokenzer variations are added, its complexity is increasing and it is hard to understand what each code block means.
We better clean up duplicated code and enhance code readability.
How has this been tested?
I don't have Cuda devices so cannot run tests. It would be great if someone can run tests for me.
Changes
Removed Duplication:
_tokenize
method which was present twice.Simplified Empty Text Handling:
Code Clarifications:
IGNORE_INDEX
replacing varied constants like-100
.Handling Unexpected Cases:
Clean-up:
Screenshots (if appropriate)
Types of changes
Readability improvement