Fix(model): Linear detected and added to target module with rope linear #738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://discord.com/channels/1104757954588196865/1110594519226925137/1163762312247787570
when lora +
rope_scaling: linear
. dynamic is ok.This condition check must've included the linear layer from the name.
Alternative solution: add blacklist for this module.
Note: I'm not sure if by removing this would affect any current run, but the linear layers listed in
cls
seems to be inclusive.