Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(params): momentarily disable early_stopping_patience until issue #73 is fixed #74

Conversation

Thytu
Copy link
Contributor

@Thytu Thytu commented May 27, 2023

No description provided.

@winglian
Copy link
Collaborator

load_best_model_at_end is derived from several factors, see
https://github.com/OpenAccess-AI-Collective/axolotl/blob/main/src/axolotl/utils/trainer.py#L115-L120

I think a good solution is allow explicit disabling of load_best_model_at_end via configuration to override all those, and if it's not specifically disabled, then add some warning in validation https://github.com/OpenAccess-AI-Collective/axolotl/blob/main/src/axolotl/utils/validation.py
if cfg.load_best_model_at_end is not False and cfg. early_stopping_patience:

@NanoCode012
Copy link
Collaborator

Closed for now. Please refer to discussion at #28 where we will try to think of better method.

@NanoCode012 NanoCode012 closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants