Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to adapt to sharegpt datasets with "assistant" rather than "gp… #774

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

MilesQLi
Copy link
Contributor

…t" as the machine answers.

This fixed issue #752.

@winglian
Copy link
Collaborator

My preference is to have this be a separate prompter, since the underlying dataset is the issue here. It's better to flag the dataset as incorrect through this process rather than ignore the issue.

@winglian
Copy link
Collaborator

@MilesQLi I updated your branch/PR so that simply adding the strict: false option will enable this behavior

  type: sharegpt
  strict: false

@winglian winglian merged commit 0800885 into axolotl-ai-cloud:main Oct 28, 2023
4 checks passed
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
axolotl-ai-cloud#774)

* Update to adapt to sharegpt datasets with "assistant" rather than "gpt" as the machine answers.

* use a strict option for hanedling incorrect turn data

* chore: lint

---------

Co-authored-by: Wing Lian <wing.lian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants