Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Set eos/bos to tokenizer if different #801

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix(config): Set eos/bos to tokenizer if different #801

merged 2 commits into from
Oct 29, 2023

Conversation

NanoCode012
Copy link
Collaborator

If the bos/eos is changed, the generated config.json does not follow the new token id. This change updates the model.config so that model.generate will respect this.

@NanoCode012 NanoCode012 merged commit 637ed09 into axolotl-ai-cloud:main Oct 29, 2023
4 checks passed
@NanoCode012 NanoCode012 deleted the fix/config-token branch October 29, 2023 12:32
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
@NanoCode012
fix(config): Set eos/bos to tokenizer if different (axolotl-ai-cloud#801
874d485 
)

* fix(config): Set eos/bos to tokenizer if different

* chore: fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NanoCode012 @winglian