Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokenizer): update log order after update #806

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

NanoCode012
Copy link
Collaborator

We should LOG the tokenizer's new token after changing, not before.

This would lead to some confusion as shown in : https://discord.com/channels/1104757954588196865/1111279858136383509/1168744957981499502

@NanoCode012 NanoCode012 merged commit 10388a8 into axolotl-ai-cloud:main Oct 31, 2023
4 checks passed
@NanoCode012 NanoCode012 deleted the fix/print-order branch October 31, 2023 04:21
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant