-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for opimum bettertransformers #92
Conversation
I checked that Pytorch link. This is not a torch 2.0 feature only right? Edit: I also see a |
so I had to add float16 as an option b/c there is no way to have the model load as float16 currently without enabling automatic mixed precision which kicks in when you pass fp16 or bf16 to the trainer. |
might be easiest to warn or raise a ValueError if they are using |
I think this is good.
I just worry this will be confusing.. Could we just check for |
what about |
Hm, by default, I think people would expect their code to be float32. Would Edit: Could you also add it to Readme in case I forget to later? |
so in doing some additional experiments, there are cases where I need to explicitly load in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some parts have been discussed before, but not sure if we decided on something.
…el to train mode:
Co-authored-by: NanoCode012 <kevinvong@rocketmail.com>
…flash-optimum add support for opimum bettertransformers
https://pytorch.org/blog/out-of-the-box-acceleration/
testing initial support for gpt-neox arch