-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added supply growth metric #7
Conversation
WalkthroughThe recent updates involve renaming the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- src/core/enums/range.enum.ts (1 hunks)
- src/modules/price/price.controller.ts (2 hunks)
- src/modules/price/schemas/range.schema.ts (1 hunks)
- src/modules/price/services/price.cache.ts (4 hunks)
- src/modules/supply/enums/supply-endpoints.enum.ts (1 hunks)
- src/modules/supply/schemas/change-range.schema.ts (1 hunks)
- src/modules/supply/schemas/growth-range.schema.ts (1 hunks)
- src/modules/supply/schemas/historical-range.schema.ts (1 hunks)
- src/modules/supply/services/supply.cache.ts (4 hunks)
- src/modules/supply/services/supply.service.ts (3 hunks)
- src/modules/supply/supply.controller.ts (3 hunks)
Files skipped from review due to trivial changes (3)
- src/modules/price/services/price.cache.ts
- src/modules/supply/enums/supply-endpoints.enum.ts
- src/modules/supply/services/supply.cache.ts
Additional comments not posted (15)
src/modules/supply/schemas/historical-range.schema.ts (1)
1-1
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for the
Range
enum,@core/enums/range.enum
, is consistently used across multiple files in the project. This confirms that the import path is correct and consistently applied in various modules, as evidenced by the successful execution of the corrected script and its output.
src/modules/supply/schemas/historical-range.schema.ts
src/modules/supply/schemas/growth-range.schema.ts
src/modules/supply/schemas/change-range.schema.ts
src/modules/price/price.controller.ts
src/modules/price/services/price.cache.ts
src/modules/price/schemas/range.schema.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files with corrected regex. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import \{ Range \} from '@core/enums/range.enum';"Length of output: 636
src/core/enums/range.enum.ts (1)
1-9
: The updatedRange
enum correctly includes the new valuesTHREE_MONTH
andYEAR
. This aligns with the PR objectives to standardize time range specifications.src/modules/supply/schemas/change-range.schema.ts (1)
1-1
: Ensure the import path forRange
is correct and consistent across the project.src/modules/supply/schemas/growth-range.schema.ts (1)
1-1
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for
Range
from@core/enums/range.enum
is consistently used across multiple files in the project. This confirms that the import path is correct and consistent as per the review comment.
src/modules/supply/supply.controller.ts
src/modules/supply/services/supply.service.ts
src/modules/supply/services/supply.cache.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all TypeScript files. # Corrected Test: Search for the import statement of `Range` with escaped curly braces. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all TypeScript files. # Adjusted Test: Use double quotes for the regex pattern to avoid shell syntax issues. Expect: Consistent import paths. rg --type ts 'import { Range } from "@core/enums/range.enum";'Length of output: 203
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all TypeScript files. # Corrected Test: Escape curly braces in the regex pattern to treat them as literals. Expect: Consistent import paths. rg --type ts 'import \{ Range \} from "@core/enums/range.enum";'Length of output: 340
src/modules/price/schemas/range.schema.ts (2)
3-3
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for
Range
from@core/enums/range.enum
is consistently used across multiple files in the project. This confirms that the import path is correct and consistently applied as per the project's standards.
- Files using the import path:
src/modules/supply/schemas/growth-range.schema.ts
src/modules/supply/schemas/change-range.schema.ts
src/modules/price/price.controller.ts
src/modules/price/services/price.cache.ts
src/modules/price/schemas/range.schema.ts
src/modules/supply/schemas/historical-range.schema.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all TypeScript files, with corrected regex. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';" --fixed-stringsLength of output: 650
6-6
: TheRangeSchema
correctly includes all the new and existingRange
values. This is well-aligned with the PR objectives to standardize the use of time range specifications.src/modules/price/price.controller.ts (2)
5-5
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for the
Range
enum is consistently used across multiple files in the project, as verified by the successful execution of the script. All referenced files importRange
from the same path@core/enums/range.enum
.
- src/modules/supply/schemas/historical-range.schema.ts
- src/modules/supply/schemas/growth-range.schema.ts
- src/modules/supply/schemas/change-range.schema.ts
- src/modules/price/price.controller.ts
- src/modules/price/services/price.cache.ts
- src/modules/price/schemas/range.schema.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';" --fixed-stringsLength of output: 650
19-19
: The methodgetHistoricalPrice
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.src/modules/supply/supply.controller.ts (4)
10-10
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for the
Range
enum is consistently used across multiple files in the project as@core/enums/range.enum
. This confirms that the import path is correct and consistent, aligning with the project's structure and the PR objectives.
- Files using the consistent import path:
src/modules/supply/schemas/historical-range.schema.ts
src/modules/supply/schemas/change-range.schema.ts
src/modules/price/price.controller.ts
src/modules/supply/schemas/growth-range.schema.ts
src/modules/price/services/price.cache.ts
src/modules/price/schemas/range.schema.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range\.enum';"Length of output: 211
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts --fixed-strings "import { Range } from '@core/enums/range.enum';"Length of output: 650
23-23
: The methodgetHistoricalSupply
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.
36-36
: The methodgetSupplyChange
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.
44-44
: The methodgetSupplyGrowth
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.src/modules/supply/services/supply.service.ts (3)
10-10
: Ensure the import path forRange
is correct and consistent across the project.Verification successful
The import path for the
Range
enum is consistently used across various files in the project as@core/enums/range.enum
. This confirms that the import path is correct and consistently applied in the codebase.
- src/modules/supply/schemas/growth-range.schema.ts
- src/modules/supply/schemas/change-range.schema.ts
- src/modules/price/services/price.cache.ts
- src/modules/price/price.controller.ts
- src/modules/price/schemas/range.schema.ts
- src/modules/supply/schemas/historical-range.schema.ts
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import { Range } from '@core/enums/range.enum';"Length of output: 209
Script:
#!/bin/bash # Description: Verify the import path for `Range` across all files. # Test: Search for the import statement of `Range`. Expect: Consistent import paths. rg --type ts "import \{ Range \} from '@core/enums/range.enum';"Length of output: 636
66-66
: The methodgetSupplyChange
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.
105-105
: The methodgetSupplyGrowth
correctly uses theRange
enum for its parameter type, aligning with the PR's goal of standardizing time range specifications.
No description provided.