-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/release docs #295
Ci/release docs #295
Conversation
WalkthroughThe recent modifications enhance the release process by integrating documentation generation and version updates for various schemas. The changes facilitate automatic documentation builds during releases and update all relevant schemas from version 3 to version 4 of the Axone ontology, ensuring consistency and alignment with the latest specifications. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD
participant Documentation
participant Git
Developer->>CI/CD: Trigger Release
CI/CD->>Documentation: Run `make docs`
Documentation-->>CI/CD: Generate Documentation
CI/CD->>Git: Commit Changes
Git-->>CI/CD: Changes Committed
CI/CD->>Developer: Release Complete
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (7)
docs/schemas/credential-digital-service-authentication.md (4)
22-22
: The updated namespace URL results in a 404 Not Found error.The URL
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/
returns a 404 Not Found error. Please verify the correct namespace URL for the latest schema version and update the documentation accordingly.
Analysis chain
Verify the updated namespace in the list of namespaces.
Ensure that the updated namespace
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/
in the list of namespaces is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated namespace in the list of namespaces. # Test: Check if the updated namespace in the list of namespaces is correct. Expect: The namespace version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/Length of output: 582
10-10
: The updated namespace versionhttps://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/
returns a 404 Not Found error, indicating it does not exist.Please verify if the v4 namespace is correct or if it should be reverted to the previous version.
- Check if the v3 namespace is the latest published version.
- Confirm the correct namespace version.
#!/bin/bash # Description: Verify available namespace versions. # List available versions in the namespace directory curl -I https://w3id.org/axone/ontology/Analysis chain
Verify the updated namespace version.
Ensure that the updated namespace version
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/
is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated namespace version. # Test: Check if the updated namespace version is correct. Expect: The namespace version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/Length of output: 582
26-26
: The updated IRI for the verifiable credential is incorrect.The IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredential
returned a 404 Not Found error. Please verify and update the IRI to ensure it points to a valid resource.
Analysis chain
Verify the updated IRI for the verifiable credential.
Ensure that the updated IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredential
is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated IRI for the verifiable credential. # Test: Check if the updated IRI for the verifiable credential is correct. Expect: The IRI version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredentialLength of output: 699
38-40
: The updated IRI for the propertytoService
returns a 404 Not Found error.This indicates that the IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toService
does not exist. Please verify the correctness of this IRI or ensure that the resource is published.
Analysis chain
Verify the updated IRI for the property
toService
.Ensure that the updated IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toService
is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated IRI for the property `toService`. # Test: Check if the updated IRI for the property `toService` is correct. Expect: The IRI version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toServiceLength of output: 591
docs/schemas/credential-digital-resource-publication.md (3)
22-22
: The updated namespace URL is incorrect.The URL
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/
returned a 404 Not Found error. Please verify the correct URL for the latest schema version and update the documentation accordingly.
- Incorrect URL:
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/
Analysis chain
Verify the updated namespace in the list of namespaces.
Ensure that the updated namespace
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/
in the list of namespaces is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated namespace in the list of namespaces. # Test: Check if the updated namespace in the list of namespaces is correct. Expect: The namespace version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/Length of output: 659
26-26
: The updated IRI for the verifiable credential is incorrect.The IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredential
returned a 404 Not Found error, indicating that the resource does not exist at this location. Please verify and update the IRI to point to the correct resource.
- Ensure that the IRI is correct and the resource is available at the specified location.
- Check for any references to the correct IRI or schema version within the repository.
Analysis chain
Verify the updated IRI for the verifiable credential.
Ensure that the updated IRI
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredential
is correct and aligns with the latest schema version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated IRI for the verifiable credential. # Test: Check if the updated IRI for the verifiable credential is correct. Expect: The IRI version is v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredentialLength of output: 616
36-38
: The IRIs for the propertieshasIdentifier
andservedBy
are incorrect.The provided IRIs
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier
andhttps://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedBy
return 404 Not Found errors. Please verify and update the IRIs to ensure they align with the latest schema version.
- Lines: 36-38
- Lines: 46-48
Analysis chain
Verify the updated IRIs for the properties
hasIdentifier
andservedBy
.Ensure that the updated IRIs
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier
andhttps://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedBy
are correct and align with the latest schema version.Also applies to: 46-48
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated IRIs for the properties `hasIdentifier` and `servedBy`. # Test: Check if the updated IRIs for the properties `hasIdentifier` and `servedBy` are correct. Expect: The IRI versions are v4. curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedByLength of output: 1183
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- .releaserc.yml (2 hunks)
- docs/schemas/credential-dataset-description.md (4 hunks)
- docs/schemas/credential-digital-resource-publication.md (3 hunks)
- docs/schemas/credential-digital-resource-rights.md (3 hunks)
- docs/schemas/credential-digital-service-authentication.md (3 hunks)
- docs/schemas/credential-digital-service-description.md (4 hunks)
- docs/schemas/credential-governance-text.md (12 hunks)
- docs/schemas/credential-orchestration-service-execution-order.md (6 hunks)
- docs/schemas/credential-orchestration-service-execution.md (7 hunks)
- docs/schemas/credential-zone-description.md (5 hunks)
Files skipped from review due to trivial changes (2)
- docs/schemas/credential-governance-text.md
- docs/schemas/credential-orchestration-service-execution-order.md
Additional context used
Gitleaks
docs/schemas/credential-digital-service-description.md
46-46: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
docs/schemas/credential-dataset-description.md
46-46: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (39)
.releaserc.yml (2)
40-40
: LGTM! Documentation files will be tracked.The inclusion of
docs/schemas/*.md
in theassets
section ensures that the generated documentation files are tracked and included in the Git commit during the release process.
25-26
: Verify themake docs
command.Ensure that the
make docs
command correctly generates the documentation. This is crucial for maintaining up-to-date documentation during the release process.Verification successful
The
make docs
command is correctly defined.The
docs
target in the Makefile is responsible for generating schema documentation and is correctly set up to run as part of the release process.
- Makefile: The
docs
target is defined and includes the necessary steps to generate documentation.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `make docs` command. # Test: Run the `make docs` command. Expect: Documentation is generated without errors. make docsLength of output: 83
Script:
#!/bin/bash # Description: Verify the presence and correctness of the `docs` target in the Makefile. # Search for the Makefile in the repository MAKEFILE=$(fd Makefile) # Check if the Makefile exists if [ -z "$MAKEFILE" ]; then echo "Makefile not found." exit 1 fi # Print the contents of the Makefile to verify the `docs` target cat "$MAKEFILE"Length of output: 18657
docs/schemas/credential-digital-resource-publication.md (1)
10-10
: Verify the updated namespace version.Ensure that the updated namespace version
https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/
is correct and aligns with the latest schema version.docs/schemas/credential-digital-resource-rights.md (6)
10-10
: Namespace update approved.The namespace has been correctly updated to version 4.
25-25
: IRI update forDigitalResourceRightsCredential
approved.The IRI has been correctly updated to version 4.
37-37
: IRI update forhasAuthor
approved.The IRI has been correctly updated to version 4.
47-47
: IRI update forhasCreator
approved.The IRI has been correctly updated to version 4.
57-57
: IRI update forhasLicense
approved.The IRI has been correctly updated to version 4.
67-67
: IRI update forhasPublisher
approved.The IRI has been correctly updated to version 4.
docs/schemas/credential-zone-description.md (8)
10-10
: Namespace update approved.The namespace has been correctly updated to version 4.
22-22
: Namespace update forthesaurus
approved.The namespace has been correctly updated to version 4.
27-27
: IRI update forZoneDescriptionCredential
approved.The IRI has been correctly updated to version 4.
41-41
: IRI updates in the JSON example approved.The IRIs have been correctly updated to version 4.
Also applies to: 44-44, 54-54
69-69
: IRI update forhasDescription
approved.The IRI has been correctly updated to version 4.
79-79
: IRI update forhasImage
approved.The IRI has been correctly updated to version 4.
89-89
: IRI update forhasTag
approved.The IRI has been correctly updated to version 4.
99-99
: IRI updates forhasTitle
andhasTopic
approved.The IRIs have been correctly updated to version 4.
Also applies to: 109-109
docs/schemas/credential-digital-service-description.md (10)
10-10
: Namespace update approved.The namespace has been correctly updated to version 4.
22-22
: Namespace update forthesaurus
approved.The namespace has been correctly updated to version 4.
27-27
: IRI update forDigitalServiceDescriptionCredential
approved.The IRI has been correctly updated to version 4.
41-41
: IRI updates in the JSON example approved.The IRIs have been correctly updated to version 4.
Also applies to: 44-44, 47-47
71-71
: IRI update forhasCategory
approved.The IRI has been correctly updated to version 4.
81-81
: IRI update forhasDescription
approved.The IRI has been correctly updated to version 4.
91-91
: IRI update forhasImage
approved.The IRI has been correctly updated to version 4.
101-101
: IRI update forhasPublisher
approved.The IRI has been correctly updated to version 4.
111-111
: IRI update forhasTag
approved.The IRI has been correctly updated to version 4.
121-121
: IRI updates forhasTitle
andhasWebpage
approved.The IRIs have been correctly updated to version 4.
Also applies to: 131-131
docs/schemas/credential-dataset-description.md (6)
10-10
: Namespace Update to Version 4The namespace URL has been correctly updated to version 4 of the Axone ontology.
22-23
: Thesaurus Namespace Update to Version 4The thesaurus namespace URL has been correctly updated to version 4 of the Axone ontology.
27-27
: IRI Update for DatasetDescriptionCredentialThe IRI for DatasetDescriptionCredential has been correctly updated to version 4.
41-44
: Example Context URL UpdateThe context URL in the example has been correctly updated to version 4.
48-57
: IRI Updates for Properties in the ExampleThe IRIs for properties in the example have been correctly updated to version 4.
72-146
: IRI Updates for Properties in the SchemaThe IRIs for properties in the schema have been correctly updated to version 4.
docs/schemas/credential-orchestration-service-execution.md (6)
10-10
: Namespace Update to Version 4The namespace URL has been correctly updated to version 4 of the Axone ontology.
26-26
: IRI Update for OrchestrationServiceExecutionCredentialThe IRI for OrchestrationServiceExecutionCredential has been correctly updated to version 4.
40-44
: IRI Update for hasExecutionThe IRI for hasExecution has been correctly updated to version 4.
64-66
: IRI Update for executionOfThe IRI for executionOf has been correctly updated to version 4.
72-72
: IRI Update for hasConsumedResourceThe IRI for hasConsumedResource has been correctly updated to version 4.
Line range hint
82-118
:
IRI Updates for Remaining PropertiesThe IRIs for the remaining properties have been correctly updated to version 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Good catch. 👍
Add the documentation generation as part of the release workflow in order to keep it updated with the new version, especially in case of major version increment.
The documentation was out of date due to the latest major release.
Summary by CodeRabbit