Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/release docs #295

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Ci/release docs #295

merged 2 commits into from
Aug 8, 2024

Conversation

amimart
Copy link
Member

@amimart amimart commented Aug 7, 2024

Add the documentation generation as part of the release workflow in order to keep it updated with the new version, especially in case of major version increment.

The documentation was out of date due to the latest major release.

Summary by CodeRabbit

  • New Features
    • Documentation generation is now integrated into the release process to ensure updates are included with code changes.
    • Updated schemas transitioning to version 4 of the Axone ontology for multiple credential types.
  • Bug Fixes
    • Resolved inconsistencies in namespace URLs across various documentation schemas to align with the latest version.

@amimart amimart self-assigned this Aug 7, 2024
@amimart amimart requested a review from ccamel August 7, 2024 13:43
Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Walkthrough

The recent modifications enhance the release process by integrating documentation generation and version updates for various schemas. The changes facilitate automatic documentation builds during releases and update all relevant schemas from version 3 to version 4 of the Axone ontology, ensuring consistency and alignment with the latest specifications.

Changes

File Path Change Summary
.releaserc.yml Updated to include prepareCmd: make docs for documentation generation and added docs/schemas/*.md to assets.
docs/schemas/*.md (multiple files) Updated all schemas from version 3 to version 4, modifying namespace URLs and IRIs for consistency.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI/CD
    participant Documentation
    participant Git

    Developer->>CI/CD: Trigger Release
    CI/CD->>Documentation: Run `make docs`
    Documentation-->>CI/CD: Generate Documentation
    CI/CD->>Git: Commit Changes
    Git-->>CI/CD: Changes Committed
    CI/CD->>Developer: Release Complete
Loading

Poem

🐇 In burrows deep, we hop and play,
With docs and schemas, bright as day.
From version three to four we leap,
In fields of code, our knowledge keeps!
Let’s cheer for changes, big and small,
For in this dance, we’ll stand up tall! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (7)
docs/schemas/credential-digital-service-authentication.md (4)

22-22: The updated namespace URL results in a 404 Not Found error.

The URL https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/ returns a 404 Not Found error. Please verify the correct namespace URL for the latest schema version and update the documentation accordingly.

Analysis chain

Verify the updated namespace in the list of namespaces.

Ensure that the updated namespace https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/ in the list of namespaces is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated namespace in the list of namespaces.

# Test: Check if the updated namespace in the list of namespaces is correct. Expect: The namespace version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/

Length of output: 582


10-10: The updated namespace version https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/ returns a 404 Not Found error, indicating it does not exist.

Please verify if the v4 namespace is correct or if it should be reverted to the previous version.

  • Check if the v3 namespace is the latest published version.
  • Confirm the correct namespace version.
#!/bin/bash
# Description: Verify available namespace versions.

# List available versions in the namespace directory
curl -I https://w3id.org/axone/ontology/
Analysis chain

Verify the updated namespace version.

Ensure that the updated namespace version https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/ is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated namespace version.

# Test: Check if the updated namespace version is correct. Expect: The namespace version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/

Length of output: 582


26-26: The updated IRI for the verifiable credential is incorrect.

The IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredential returned a 404 Not Found error. Please verify and update the IRI to ensure it points to a valid resource.

Analysis chain

Verify the updated IRI for the verifiable credential.

Ensure that the updated IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredential is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated IRI for the verifiable credential.

# Test: Check if the updated IRI for the verifiable credential is correct. Expect: The IRI version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/DigitalServiceAuthenticationCredential

Length of output: 699


38-40: The updated IRI for the property toService returns a 404 Not Found error.

This indicates that the IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toService does not exist. Please verify the correctness of this IRI or ensure that the resource is published.

Analysis chain

Verify the updated IRI for the property toService.

Ensure that the updated IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toService is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated IRI for the property `toService`.

# Test: Check if the updated IRI for the property `toService` is correct. Expect: The IRI version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-service/authentication/toService

Length of output: 591

docs/schemas/credential-digital-resource-publication.md (3)

22-22: The updated namespace URL is incorrect.

The URL https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/ returned a 404 Not Found error. Please verify the correct URL for the latest schema version and update the documentation accordingly.

  • Incorrect URL: https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/
Analysis chain

Verify the updated namespace in the list of namespaces.

Ensure that the updated namespace https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/ in the list of namespaces is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated namespace in the list of namespaces.

# Test: Check if the updated namespace in the list of namespaces is correct. Expect: The namespace version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/

Length of output: 659


26-26: The updated IRI for the verifiable credential is incorrect.

The IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredential returned a 404 Not Found error, indicating that the resource does not exist at this location. Please verify and update the IRI to point to the correct resource.

  • Ensure that the IRI is correct and the resource is available at the specified location.
  • Check for any references to the correct IRI or schema version within the repository.
Analysis chain

Verify the updated IRI for the verifiable credential.

Ensure that the updated IRI https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredential is correct and aligns with the latest schema version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated IRI for the verifiable credential.

# Test: Check if the updated IRI for the verifiable credential is correct. Expect: The IRI version is v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/DigitalResourcePublicationCredential

Length of output: 616


36-38: The IRIs for the properties hasIdentifier and servedBy are incorrect.

The provided IRIs https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier and https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedBy return 404 Not Found errors. Please verify and update the IRIs to ensure they align with the latest schema version.

  • Lines: 36-38
  • Lines: 46-48
Analysis chain

Verify the updated IRIs for the properties hasIdentifier and servedBy.

Ensure that the updated IRIs https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier and https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedBy are correct and align with the latest schema version.

Also applies to: 46-48

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the updated IRIs for the properties `hasIdentifier` and `servedBy`.

# Test: Check if the updated IRIs for the properties `hasIdentifier` and `servedBy` are correct. Expect: The IRI versions are v4.
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/hasIdentifier
curl -I https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/servedBy

Length of output: 1183

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 47ad281 and 9af73a2.

Files selected for processing (10)
  • .releaserc.yml (2 hunks)
  • docs/schemas/credential-dataset-description.md (4 hunks)
  • docs/schemas/credential-digital-resource-publication.md (3 hunks)
  • docs/schemas/credential-digital-resource-rights.md (3 hunks)
  • docs/schemas/credential-digital-service-authentication.md (3 hunks)
  • docs/schemas/credential-digital-service-description.md (4 hunks)
  • docs/schemas/credential-governance-text.md (12 hunks)
  • docs/schemas/credential-orchestration-service-execution-order.md (6 hunks)
  • docs/schemas/credential-orchestration-service-execution.md (7 hunks)
  • docs/schemas/credential-zone-description.md (5 hunks)
Files skipped from review due to trivial changes (2)
  • docs/schemas/credential-governance-text.md
  • docs/schemas/credential-orchestration-service-execution-order.md
Additional context used
Gitleaks
docs/schemas/credential-digital-service-description.md

46-46: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

docs/schemas/credential-dataset-description.md

46-46: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

Additional comments not posted (39)
.releaserc.yml (2)

40-40: LGTM! Documentation files will be tracked.

The inclusion of docs/schemas/*.md in the assets section ensures that the generated documentation files are tracked and included in the Git commit during the release process.


25-26: Verify the make docs command.

Ensure that the make docs command correctly generates the documentation. This is crucial for maintaining up-to-date documentation during the release process.

Verification successful

The make docs command is correctly defined.

The docs target in the Makefile is responsible for generating schema documentation and is correctly set up to run as part of the release process.

  • Makefile: The docs target is defined and includes the necessary steps to generate documentation.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the `make docs` command.

# Test: Run the `make docs` command. Expect: Documentation is generated without errors.
make docs

Length of output: 83


Script:

#!/bin/bash
# Description: Verify the presence and correctness of the `docs` target in the Makefile.

# Search for the Makefile in the repository
MAKEFILE=$(fd Makefile)

# Check if the Makefile exists
if [ -z "$MAKEFILE" ]; then
  echo "Makefile not found."
  exit 1
fi

# Print the contents of the Makefile to verify the `docs` target
cat "$MAKEFILE"

Length of output: 18657

docs/schemas/credential-digital-resource-publication.md (1)

10-10: Verify the updated namespace version.

Ensure that the updated namespace version https://w3id.org/axone/ontology/v4/schema/credential/digital-resource/publication/ is correct and aligns with the latest schema version.

docs/schemas/credential-digital-resource-rights.md (6)

10-10: Namespace update approved.

The namespace has been correctly updated to version 4.


25-25: IRI update for DigitalResourceRightsCredential approved.

The IRI has been correctly updated to version 4.


37-37: IRI update for hasAuthor approved.

The IRI has been correctly updated to version 4.


47-47: IRI update for hasCreator approved.

The IRI has been correctly updated to version 4.


57-57: IRI update for hasLicense approved.

The IRI has been correctly updated to version 4.


67-67: IRI update for hasPublisher approved.

The IRI has been correctly updated to version 4.

docs/schemas/credential-zone-description.md (8)

10-10: Namespace update approved.

The namespace has been correctly updated to version 4.


22-22: Namespace update for thesaurus approved.

The namespace has been correctly updated to version 4.


27-27: IRI update for ZoneDescriptionCredential approved.

The IRI has been correctly updated to version 4.


41-41: IRI updates in the JSON example approved.

The IRIs have been correctly updated to version 4.

Also applies to: 44-44, 54-54


69-69: IRI update for hasDescription approved.

The IRI has been correctly updated to version 4.


79-79: IRI update for hasImage approved.

The IRI has been correctly updated to version 4.


89-89: IRI update for hasTag approved.

The IRI has been correctly updated to version 4.


99-99: IRI updates for hasTitle and hasTopic approved.

The IRIs have been correctly updated to version 4.

Also applies to: 109-109

docs/schemas/credential-digital-service-description.md (10)

10-10: Namespace update approved.

The namespace has been correctly updated to version 4.


22-22: Namespace update for thesaurus approved.

The namespace has been correctly updated to version 4.


27-27: IRI update for DigitalServiceDescriptionCredential approved.

The IRI has been correctly updated to version 4.


41-41: IRI updates in the JSON example approved.

The IRIs have been correctly updated to version 4.

Also applies to: 44-44, 47-47


71-71: IRI update for hasCategory approved.

The IRI has been correctly updated to version 4.


81-81: IRI update for hasDescription approved.

The IRI has been correctly updated to version 4.


91-91: IRI update for hasImage approved.

The IRI has been correctly updated to version 4.


101-101: IRI update for hasPublisher approved.

The IRI has been correctly updated to version 4.


111-111: IRI update for hasTag approved.

The IRI has been correctly updated to version 4.


121-121: IRI updates for hasTitle and hasWebpage approved.

The IRIs have been correctly updated to version 4.

Also applies to: 131-131

docs/schemas/credential-dataset-description.md (6)

10-10: Namespace Update to Version 4

The namespace URL has been correctly updated to version 4 of the Axone ontology.


22-23: Thesaurus Namespace Update to Version 4

The thesaurus namespace URL has been correctly updated to version 4 of the Axone ontology.


27-27: IRI Update for DatasetDescriptionCredential

The IRI for DatasetDescriptionCredential has been correctly updated to version 4.


41-44: Example Context URL Update

The context URL in the example has been correctly updated to version 4.


48-57: IRI Updates for Properties in the Example

The IRIs for properties in the example have been correctly updated to version 4.


72-146: IRI Updates for Properties in the Schema

The IRIs for properties in the schema have been correctly updated to version 4.

docs/schemas/credential-orchestration-service-execution.md (6)

10-10: Namespace Update to Version 4

The namespace URL has been correctly updated to version 4 of the Axone ontology.


26-26: IRI Update for OrchestrationServiceExecutionCredential

The IRI for OrchestrationServiceExecutionCredential has been correctly updated to version 4.


40-44: IRI Update for hasExecution

The IRI for hasExecution has been correctly updated to version 4.


64-66: IRI Update for executionOf

The IRI for executionOf has been correctly updated to version 4.


72-72: IRI Update for hasConsumedResource

The IRI for hasConsumedResource has been correctly updated to version 4.


Line range hint 82-118:
IRI Updates for Remaining Properties

The IRIs for the remaining properties have been correctly updated to version 4.

Copy link

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good !

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Good catch. 👍

@amimart amimart merged commit c68379e into main Aug 8, 2024
10 checks passed
@amimart amimart deleted the ci/release-docs branch August 8, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants