Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint9 #246

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Eslint9 #246

merged 1 commit into from
Jan 3, 2025

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Dec 16, 2024 •
edited
Loading

  • Update to EsLint v9 (and flat config)
  • Raise ts lint rules to strict (more than just recommended)
    -> hint: we could also enable eslint rules based on types which are even more accurate (e.g. recommendedWithTypes or scriptWithTypes), however they need more time to adjust I think
  • Testing library with react (was only the default it seems)
  • Add playwright eslint plugin
  • Add tanstack/query eslint plugin
  • Fix various lint problems

@ivy-lli ivy-lli force-pushed the eslint9 branch 2 times, most recently from e512ac7 to 1ca1a46 Compare January 3, 2025 08:46
@ivy-lli ivy-lli changed the base branch from release/12.0 to master January 3, 2025 08:46
@ivy-lli ivy-lli marked this pull request as ready for review January 3, 2025 08:46
@ivy-lli ivy-lli requested review from ivy-cst and ivy-edp January 3, 2025 08:57
ivy-cst
ivy-cst approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@ivy-cst ivy-cst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

integrations/standalone/src/mock/validation-mock.ts Outdated Show resolved Hide resolved
integrations/standalone/src/mock/validation-mock.ts Outdated Show resolved Hide resolved
@ivy-lli
Update to eslint v9
696a187 
- Update to EsLint v9 (and flat config)
- Raise ts lint rules to strict (more than just recommended)
  -> hint: we could also enable eslint rules based on types which are even more accurate (e.g. recommendedWithTypes or scriptWithTypes), however they need more time to adjust I think
- Testing library with react (was only the default it seems)
- Add playwright eslint plugin
- Add tanstack/query eslint plugin
- Fix various lint problems
@ivy-lli ivy-lli merged commit 9a2eb3a into master Jan 3, 2025
10 checks passed
@ivy-lli ivy-lli deleted the eslint9 branch January 3, 2025 09:30
ivy-edp
ivy-edp reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@ivy-edp ivy-edp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good, thanks 👍
I guess we can now also use the ESLint Config Inspector? https://eslint.org/blog/2024/04/eslint-config-inspector/

@ivy-lli
Copy link
Member Author

ivy-lli commented Jan 3, 2025

Nice looks good, thanks 👍 I guess we can now also use the ESLint Config Inspector? https://eslint.org/blog/2024/04/eslint-config-inspector/

yes just run script: https://github.com/axonivy/form-editor-client/pull/246/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21

@ivy-edp
Copy link
Member

ivy-edp commented Jan 3, 2025

Nice looks good, thanks 👍 I guess we can now also use the ESLint Config Inspector? https://eslint.org/blog/2024/04/eslint-config-inspector/

yes just run script: https://github.com/axonivy/form-editor-client/pull/246/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21

Very cool 👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-edp ivy-edp ivy-edp left review comments

@ivy-cst ivy-cst ivy-cst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivy-lli @ivy-edp @ivy-cst