Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings #460

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix deprecation warnings #460

merged 1 commit into from
Jul 19, 2024

Conversation

alexsuter
Copy link
Member

  • Enable deprecation warnings in build
  • Use Java Compiler recorder intead of ECJ

@alexsuter
Fix deprecation warnings
787e393 
- Enable deprecation warnings in build
- Use Java Compiler recorder intead of ECJ
@alexsuter alexsuter requested a review from ivy-lmu July 19, 2024 13:03
@alexsuter alexsuter merged commit b7b4b33 into master Jul 19, 2024
6 checks passed
@alexsuter alexsuter deleted the java-compiler-warnings branch July 19, 2024 13:09
ivy-lmu
ivy-lmu approved these changes Jul 19, 2024
View reviewed changes
src/main/java/ch/ivyteam/ivy/maven/util/MavenDependencies.java
String artifactKey = artifact.getGroupId() + ":" + artifact.getArtifactId() + ":" + artifact.getVersion();
MavenProject reactorProject = projects.get(artifactKey);
return Optional.ofNullable(reactorProject);
return session.getAllProjects().stream()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAllProjects() cannot be null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hope so. Otherwise I will add a null check :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right place for hope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God bless you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-lmu ivy-lmu ivy-lmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsuter @ivy-lmu