Removing the drop and gathers in depth tensor parallelism for the easy API #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth9820
changed the title
This was referenced Feb 28, 2024
Avuxon
pushed a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that these are unnecessary. Instead the drop can happen inside the dataloader if we shard it correctly. In the case of lightning or accelerate (a PR making this change is here - axonn-ai/accelerate#2), this sharding will be handled by the backend. For users directly using axonn (like improved-diffusion), we must provide some api for them to configure their dataloaders.