Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove outdated cross chain code #1085

Merged
merged 6 commits into from
Mar 16, 2023
Merged

refactor: remove outdated cross chain code #1085

merged 6 commits into from
Mar 16, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Mar 15, 2023 •
edited
Loading

What this PR does / why we need it:

This PR

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner March 15, 2023 16:51
@KaoImin KaoImin requested review from hongda3141 and liya2017 March 15, 2023 16:51
@KaoImin KaoImin changed the title refactor: remove outdated cross chain code This is wrong case Mar 15, 2023
@KaoImin KaoImin changed the title This is wrong case refactor: remove outdated cross chain code Mar 15, 2023
@KaoImin KaoImin changed the title refactor: remove outdated cross chain code test Mar 16, 2023
@liya2017 liya2017 changed the title test test pr lint Mar 16, 2023
@KaoImin KaoImin changed the title test pr lint refactor: remove outdated cross chain code Mar 16, 2023
@KaoImin KaoImin requested a review from driftluo March 16, 2023 02:59
@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 16, 2023

/run-ci

1 similar comment
@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 16, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 16, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

1 similar comment
@axon-bot
Copy link

axon-bot bot commented Mar 16, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 16, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 16, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

driftluo
driftluo reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@driftluo driftluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/axonweb3/axon/blob/main/devtools/chain/config.toml should also remove these Configuration

@KaoImin KaoImin added this pull request to the merge queue Mar 16, 2023
Merged via the queue into main with commit fce5bf2 Mar 16, 2023
@KaoImin KaoImin deleted the refactor branch March 17, 2023 03:55
@yangby-cryptape yangby-cryptape mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@hongda3141 hongda3141 Awaiting requested review from hongda3141 hongda3141 is a code owner automatically assigned from axonweb3/axon-dev

@liya2017 liya2017 Awaiting requested review from liya2017 liya2017 is a code owner automatically assigned from axonweb3/axon-dev

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaoImin @driftluo