-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use constant values as default values #1320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckngm
previously approved these changes
Aug 15, 2023
KaoImin
previously approved these changes
Aug 15, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
changed the title
perf: use constant values as default values
perf!: use constant values as default values
Aug 15, 2023
This PR should be refactor rather than perf. |
yangby-cryptape
force-pushed
the
yangby/refactor/unify-default-roots
branch
2 times, most recently
from
August 15, 2023 08:02
885aea6
to
60bd51b
Compare
yangby-cryptape
changed the title
perf!: use constant values as default values
refactor: use constant values as default values
Aug 15, 2023
KaoImin
previously approved these changes
Aug 15, 2023
KaoImin
changed the title
refactor: use constant values as default values
refactor!: use constant values as default values
Aug 15, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
@KaoImin There is no break changes. |
KaoImin
changed the title
refactor!: use constant values as default values
refactor: use constant values as default values
Aug 15, 2023
KaoImin
requested review from
blckngm and
Flouse
and removed request for
wenyuanhust and
Simon-Tl
August 15, 2023 09:47
@yangby-cryptape need to rebase |
yangby-cryptape
force-pushed
the
yangby/refactor/unify-default-roots
branch
from
August 16, 2023 01:03
60bd51b
to
ff8900f
Compare
KaoImin
approved these changes
Aug 16, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
blckngm
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this PR, some values use constant values to set the default values, and some are not.
Click for example.
axon/core/consensus/src/engine.rs
Lines 71 to 79 in 4ef2f56
In fact, the above code is the same as
The only difference is avoiding some computations, so that improve a little performance.
In this PR:
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #1318
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc
CI Usage
CI Switch