-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refactor web_compatible
workflow
#1392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIx Error: Unhandled error: HttpError: Validation Failed: {"resource":"Status","code":"custom","field":"sha","message":"sha must be a 40 character SHA1"}
Flouse
commented
Sep 1, 2023
KaoImin
previously approved these changes
Sep 1, 2023
Flouse
commented
Sep 1, 2023
KaoImin
approved these changes
Sep 1, 2023
@yangby-cryptape @blckngm Please review this PR. |
blckngm
approved these changes
Sep 4, 2023
This was referenced Sep 17, 2023
Closed
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR tries to make CIs simpler.
/run-ci
workflow #1385, Deprecate AXON_BOT_APP #1390 in .github/workflows/web3_compatible.ymlworkflows/web3_compatible.yml
job.dispatch-web3-compatible
andjob.web3-compatible
into one job, since their code were almost the same => less codeCode Format
workflow doesn't require inputs.dispatchWhat is the impact of this PR?
Special notes for your reviewer:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc