Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rust toolchain to 1.72 #1393

Merged
merged 2 commits into from
Sep 6, 2023
Merged

chore: upgrade rust toolchain to 1.72 #1393

merged 2 commits into from
Sep 6, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Sep 1, 2023

What this PR does / why we need it?

This PR upgrades rust toolchain to 1.72. The mainly reason is:

Rust reports potentially useful cfg-disabled items in errors

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin requested a review from a team as a code owner September 1, 2023 08:15
@KaoImin KaoImin requested review from jjyr and wenyuanhust September 1, 2023 08:15
@github-actions github-actions bot added the chore label Sep 1, 2023
@KaoImin KaoImin requested review from driftluo and yangby-cryptape and removed request for jjyr and wenyuanhust September 1, 2023 08:15
@KaoImin

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@KaoImin KaoImin requested review from Flouse and blckngm September 1, 2023 08:17
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update Dockerfile too?

FROM rust:1.70 as builder

@Flouse Flouse self-requested a review September 1, 2023 08:26
core/mempool/src/adapter/mod.rs Show resolved Hide resolved
@KaoImin KaoImin enabled auto-merge September 1, 2023 09:29
@Flouse Flouse disabled auto-merge September 1, 2023 11:30
@Flouse Flouse marked this pull request as draft September 5, 2023 03:01
@Flouse Flouse self-requested a review September 5, 2023 03:01
@KaoImin KaoImin marked this pull request as ready for review September 5, 2023 14:26
@KaoImin KaoImin added this pull request to the merge queue Sep 5, 2023
@KaoImin KaoImin removed this pull request from the merge queue due to a manual request Sep 5, 2023
@KaoImin KaoImin force-pushed the upgrade-rust-toolchain branch from 03f5e6f to 108f261 Compare September 5, 2023 15:24
@KaoImin KaoImin enabled auto-merge September 5, 2023 15:24
@KaoImin

This comment was marked as off-topic.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

CI tests run on commit:

CI test list:

  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit f8d9b50 Sep 6, 2023
@KaoImin KaoImin deleted the upgrade-rust-toolchain branch September 20, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants