Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the check logic for Axon node status #1446

Merged
merged 2 commits into from
Sep 22, 2023
Merged

ci: fix the check logic for Axon node status #1446

merged 2 commits into from
Sep 22, 2023

Conversation

sunchengzhu
Copy link
Collaborator

@sunchengzhu sunchengzhu commented Sep 21, 2023 •
edited by Flouse
Loading

What this PR does / why we need it?

This PR is used to fix the problem of #1445

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@sunchengzhu sunchengzhu requested a review from a team as a code owner September 21, 2023 15:52
@yangby-cryptape
Copy link
Collaborator

Today, sleep 20.

With more code added, sleep 30 next week, sleep 40 next month, ...

I think such unpredictable tests should NOT be CI checks.

@sunchengzhu
Copy link
Collaborator Author

Today, sleep 20.

With more code added, sleep 30 next week, sleep 40 next month, ...

I think such unpredictable tests should NOT be CI checks.

@yangby-cryptape
I sbmitted a new commit to solve the problem you mentioned.

Flouse added a commit to Flouse/axon that referenced this pull request Sep 22, 2023
@Flouse
ci: deprecate the build-axon workflow
9cc441d 
due to PR axonweb3#1446 and issue axonweb3#1387
@Flouse Flouse mentioned this pull request Sep 22, 2023
Merged
7 tasks
@Flouse

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@Flouse Flouse changed the title fix: sleep 20s to wait for the Axon node to start ci: fix the check logic for Axon node status Sep 22, 2023
@Flouse

This comment was marked as outdated.

Sign in to view
Flouse
Flouse requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests on Axon commit a3ba757 failed

image

@KaoImin
Copy link
Contributor

KaoImin commented Sep 22, 2023

/run-ci

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@sunchengzhu sunchengzhu changed the base branch from main to scz/support-run-ci September 22, 2023 07:01
@sunchengzhu sunchengzhu changed the base branch from scz/support-run-ci to main September 22, 2023 07:05
@Flouse Flouse merged commit cc20484 into axonweb3:main Sep 22, 2023
Flouse added a commit to Flouse/axon that referenced this pull request Sep 22, 2023
@Flouse
ci: deprecate the build-axon workflow
94051ae 
due to PR axonweb3#1446 and issue axonweb3#1387
Flouse added a commit to Flouse/axon that referenced this pull request Sep 22, 2023
@Flouse
ci: deprecate the build-axon workflow
7d1e6c5 
due to PR axonweb3#1446 and issue axonweb3#1387
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2023
@Flouse
ci: deprecate the build-axon workflow (#1447)
9ce5aa0 
* ci: deprecate the `build-axon` workflow

due to PR #1446 and issue #1387

* ci: update the cache key for `cargo build`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@yangby-cryptape yangby-cryptape yangby-cryptape left review comments

@KaoImin KaoImin Awaiting requested review from KaoImin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunchengzhu @yangby-cryptape @Flouse @KaoImin