refactor(cli): initialize chain without any secret key #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
force-pushed
the
yangby/refactor/no-key-when-init
branch
from
81cfc98 to
fddc5e3
Compare
yangby-cryptape
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
requested review from
ashuralyk and
wenyuanhust
and removed request for
ashuralyk and
wenyuanhust
yangby-cryptape
force-pushed
the
yangby/refactor/no-key-when-init
branch
from
fddc5e3 to
45aca20
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
force-pushed
the
yangby/refactor/no-key-when-init
branch
from
45aca20 to
0bfd3e8
Compare
Because only the workflow scripts in default branch will be called. |
Flouse
approved these changes
Oct 11, 2023
KaoImin
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR remove the
keyparameter from theinitsub-command.Since #1454, the secret is not required anymore.
What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description