Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable estimation mode for query apis #1603

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Nov 28, 2023

What this PR does / why we need it?

This PR may resolves #1286.

Ref:

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

p.s. This PR is created via GitHub CLI.

@yangby-cryptape
Copy link
Collaborator Author

/run-ci

p.s. This comment is created via GitHub CLI.

Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review November 28, 2023 11:53
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner November 28, 2023 11:53
@yangby-cryptape yangby-cryptape requested review from ashuralyk, Simon-Tl, Flouse and KaoImin and removed request for ashuralyk and Simon-Tl November 28, 2023 11:53
KaoImin
KaoImin previously approved these changes Nov 29, 2023
@Flouse Flouse requested a review from driftluo November 29, 2023 03:54
Flouse
Flouse previously approved these changes Nov 29, 2023
core/executor/src/lib.rs Show resolved Hide resolved
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
@yangby-cryptape yangby-cryptape dismissed stale reviews from Flouse and KaoImin via cfcbcd5 November 29, 2023 04:35
@Flouse Flouse merged commit 0375d87 into main Nov 29, 2023
21 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/bugfix/estimate-gas branch November 29, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axon returns too low eth_estimateGas which is not enough for the transaction execution
3 participants