Python38 as default (SeldonIO#3591)

* make pyhon 3.8 default * add ugprading note * Update doc/source/reference/images.md Co-authored-by: Alex Rakowski <alex.g.rakowski@gmail.com> * Update images.md Co-authored-by: Alex Rakowski <alex.g.rakowski@gmail.com>
axsaucedo · Sep 20, 2021 · 0d0c826 · 0d0c826
1 parent 0699f0b
commit 0d0c826
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/doc/source/reference/images.md b/doc/source/reference/images.md
@@ -21,13 +21,13 @@
 
 | Description | Image URL | Stable Version | Development |
 |-------------|-----------|----------------|-------------|
-| [Seldon Python 3 (3.7) Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python3](https://hub.docker.com/r/seldonio/seldon-core-s2i-python3/tags/) | 1.10.0 | 1.11.0-dev |
+| [Seldon Python 3 (3.8) Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python3](https://hub.docker.com/r/seldonio/seldon-core-s2i-python3/tags/) | 1.10.0 | 1.11.0-dev |
 | [Seldon Python 3.6 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36/tags/) | 1.10.0 | 1.11.0-dev |
 | [Seldon Python 3.7 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37/tags/) | 1.10.0 | 1.11.0-dev |
-| [Seldon Python 3.7 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38/tags/) |       | 1.11.0-dev |
+| [Seldon Python 3.8 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38/tags/) |  1.10.0  | 1.11.0-dev |
 | [Seldon Python 3.6 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36-gpu/tags/) | 1.10.0 | 1.11.0-dev |
 | [Seldon Python 3.7 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37-gpu/tags/) | 1.10.0 | 1.11.0-dev |
-| [Seldon Python 3.8 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38-gpu/tags/) |       | 1.11.0-dev |
+| [Seldon Python 3.8 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38-gpu/tags/) | 1.10.0 | 1.11.0-dev |
 
 ## Server proxies
 

diff --git a/doc/source/reference/upgrading.md b/doc/source/reference/upgrading.md
@@ -6,6 +6,14 @@ If you were running our Openshift 0.4.2 certified operator and are looking to up
 
 Make sure you also [read the CHANGELOG](./changelog.html) to see the detailed features and bug-fixes in each version.
 
+## Upgrading to 1.11
+
+### Python S2I Wrapper
+
+  * The default wrapper `seldonio/seldon-core-s2i-python3` is now Python 3.8
+  * Python 3.7 wrapper is still available as `seldonio/seldon-core-s2i-python37`
+
+
 ## Upgrading to 1.10
 
 ### Seldon Core Wrapper

diff --git a/wrappers/s2i/python/Makefile b/wrappers/s2i/python/Makefile
@@ -1,7 +1,7 @@
 IMAGE_VERSION := $(shell cat ../../../version.txt)
 SHELL:=/bin/bash
 
-PYTHON_VERSION=3.7.10
+PYTHON_VERSION=3.8.10
 
 CONDA_DOWNLOAD_VERSION=4.7.12
 CONDA_VERSION=4.10.3

diff --git a/wrappers/s2i/python/build_scripts/build_all.sh b/wrappers/s2i/python/build_scripts/build_all.sh
@@ -7,7 +7,7 @@ make -C ../ build PYTHON_VERSION=3.7.10
 make -C ../ build PYTHON_VERSION=3.8.10
 
 # Tag the default image
-make -C ../ tag_base_python PYTHON_VERSION=3.7.10
+make -C ../ tag_base_python PYTHON_VERSION=3.8.10
 
 # Build GPU images
 make -C ../ build_gpu PYTHON_VERSION=3.6

diff --git a/wrappers/s2i/python/build_scripts/push_all.sh b/wrappers/s2i/python/build_scripts/push_all.sh
@@ -7,7 +7,7 @@ make -C ../ push_to_dockerhub PYTHON_VERSION=3.7.10
 make -C ../ push_to_dockerhub PYTHON_VERSION=3.8.10
 
 # Push default tag image
-make -C ../ push_to_dockerhub_base_python PYTHON_VERSION=3.7.10
+make -C ../ push_to_dockerhub_base_python PYTHON_VERSION=3.8.10
 
 # Push GPU images
 make -C ../ push_gpu_to_dockerhub PYTHON_VERSION=3.6