Choose Rack headers class depending on availability #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rack 3.0.0 deprecates Rack::Utils::HeaderHash, warns that the class will be removed in Rack 3.1, and suggests using Rack::Headers, instead. This change uses the Rack::Headers class, if it is defined (i.e. if rack >= 3.0.0 is installed), and otherwise falls back to using Rack::Utils::HeaderHash (i.e. for rack < 3.0.0).
Closed
|
I tested this change against my app using both Rack 3.0.9 (in which case this forked branch of |
davidrunger
added a commit
to davidrunger/david_runger
that referenced
this pull request
Feb 20, 2024
|
Thanks! Released as |
|
@axsuul Thank you so much for the quick merge and release! 🚀 It's an honor to have been added to the CHANGELOG and to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75
Rack 3.0.0 deprecates Rack::Utils::HeaderHash, warns that the class will be removed in Rack 3.1, and suggests using Rack::Headers, instead. This change uses the Rack::Headers class, if it is defined (i.e. if rack >= 3.0.0 is installed), and otherwise falls back to using Rack::Utils::HeaderHash (i.e. for rack < 3.0.0).