include/command.h: correct to use enum command_ret_t for cmd_process() #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types of declaration cmd_process() are conflict in command.c and common.h, correct to use "enum command_ret_t" for the declaration in common.h to fix below compile error: | command.c:515:20: error: conflicting types for 'cmd_process' due to enum/integer mismatch; have 'enum command_ret_t(int, int, char * const*, int *)' [-Werror=enum-int-mismatch] | 515 | enum command_ret_t cmd_process(int flag, int argc, char * const argv[], | | ^~~~~~~~~~~ | In file included from include/image.h:50, | from include/common.h:118, | from command.c:28: | include/command.h:144:5: note: previous declaration of 'cmd_process' with type 'int(int, int, char * const*, int *)' | 144 | int cmd_process(int flag, int argc, char * const argv[], Signed-off-by: Liwei Song <liwei.song@windriver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types of declaration cmd_process() are conflict in command.c and common.h, correct to use "enum command_ret_t" for the declaration in common.h to fix below compile error:
| command.c:515:20: error: conflicting types for 'cmd_process' due to enum/integer mismatch; have 'enum command_ret_t(int, int, char * const*, int )' [-Werror=enum-int-mismatch]
| 515 | enum command_ret_t cmd_process(int flag, int argc, char * const argv[],
| | ^~~~~~~~~~~
| In file included from include/image.h:50,
| from include/common.h:118,
| from command.c:28:
| include/command.h:144:5: note: previous declaration of 'cmd_process' with type 'int(int, int, char * const, int *)'
| 144 | int cmd_process(int flag, int argc, char * const argv[],