aya: Support multiple maps in map sections #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-tucker
force-pushed
the
multimap
branch
2 times, most recently
from
5bf1668 to
8536ec8
Compare
dave-tucker
added
aya
|
I'll review this soon but first - have you tried it with stripped binaries? |
|
I haven't, but I can do |
dave-tucker
added a commit
to dave-tucker/aya
that referenced
this pull request
Apr 27, 2022
This forces all maps to the maps section so we remain compatible with libbpf. This requires aya-rs#181 to avoid breaking userspace. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
alessandrod
requested changes
Apr 28, 2022
dave-tucker
force-pushed
the
multimap
branch
5 times, most recently
from
5cbcd5e to
b34d0a1
Compare
|
@alessandrod ready for another look. This time around I decided to read into the section data from the address/size in the symbols table, so we can support definitions that are different lengths. The only drawback is that we don't verify all of the section data has been consumed... |
alessandrod
requested changes
Apr 29, 2022
This commit uses the symbol table to discover all maps inside an ELF section. Instead of doing what libbpf does - divide the section data in to equal sized chunks - we read in to section data using the symbol address and offset, thus allowing us to support definitions of varying lengths. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
@alessandrod nits addressed... and while I was editing the test I threw in some padding between the last |
alessandrod
approved these changes
Apr 30, 2022
dave-tucker
added a commit
to dave-tucker/aya
that referenced
this pull request
May 3, 2022
This forces all maps to the maps section so we remain compatible with libbpf. This requires aya-rs#181 to avoid breaking userspace. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
fasterthanlime
pushed a commit
to fasterthanlime/aya
that referenced
this pull request
May 20, 2022
This forces all maps to the maps section so we remain compatible with libbpf. This requires aya-rs#181 to avoid breaking userspace. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the symbol table to discover all maps inside an ELF
section. We then divide the data in to equal sized chunks and parse them
using parse_map_def
Signed-off-by: Dave Tucker dave@dtucker.co.uk