integration-test: Remove runtime toolchain deps #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tamird
force-pushed
the
reloc-tests
branch
6 times, most recently
from
d49aa54
to
98a7567
Compare
|
This happens to reduce CI time as well because of better caching; previously the integration tests weren't enjoying the benefits of |
ajwerner
approved these changes
Jul 31, 2023
tamird
force-pushed
the
reloc-tests
branch
5 times, most recently
from
3f47543
to
f97a4b8
Compare
|
Turns out the tests weren't running (because github artifacts strip the execute bit). They're running now, adding about 90 seconds. |
Could parallelize the building and running in the two profiles to regain some speed I reckon. |
dave-tucker
reviewed
Aug 1, 2023
tamird
force-pushed
the
reloc-tests
branch
5 times, most recently
from
ff83359
to
44cb1c9
Compare
One case manually adjusted to `assert_matches!`.
Move the use of clang and llvm-objcopy from run-time to build-time. This allows the integration tests to run on VMs with simpler userlands. Create a new CI job to build the integration tests separately from running them. Ship them from that job to the runner job using github actions artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the use of clang and llvm-objcopy from run-time to build-time. This
allows the integration tests to run on VMs with simpler userlands.
Create a new CI job to build the integration tests separately from
running them. Ship them from that job to the runner job using github
actions artifacts.