uprobe,integration-test: do not exercise dylib resolution in integration tests

[ajwerner]

See individual commits.

---

This change is 

[netlify]

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	79c9489
🔍 Latest deploy log	https://app.netlify.com/sites/aya-rs-docs/deploys/64ca69f3a886c3000872d115
😎 Deploy Preview	https://deploy-preview-717--aya-rs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[tamird]

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @ajwerner)

---

-- commits line 6 at r1:
"in anticipation"

---

-- commits line 13 at r2:
"isn't part of" is an odd wording. Isn't referenced from?

---

-- commits line 17 at r2:
how could that oddity be addressed? the bit about the absolute path? i think there's a nicer way to phrase what this commit does or does not do.

---

.github/workflows/ci.yml line 231 at r2 (raw file):

  build-workflow-complete:
    needs:
      ["lint", "build-test-aya", "build-test-aya-bpf", "run-integration-test"]

seems unrelated

---

aya/src/programs/uprobe.rs line 126 at r1 (raw file):

}

// Look up the path for the target. If it there is a pid, and the target is a library name

this commentary may be better placed inside the body; it describes the implementation rather than the contract.

---

aya/src/programs/uprobe.rs line 133 at r1 (raw file):

) -> Result<String, UProbeError> {
    let target = target.as_ref();
    let target_str = &*target.as_os_str().to_string_lossy();

there are several unnecessary conversions and allocations happening here. I realize you're just moving code around, so feel free to disregard.

---

aya/src/programs/uprobe.rs line 166 at r1 (raw file):

// be dynamically linked to libc and can exercise resolving the path to libc via the current
// process's memory map.
#[cfg(all(target_os = "linux", target_env = "gnu"))]

we should compile this test always, but only run it on linux-gnu.

#[cfg_attr(not(all(target_os = "linux", target_env = "gnu")), ignore = "something descriptive goes here"]

---

aya/src/programs/uprobe.rs line 174 at r1 (raw file):

    // Now let's resolve the path to libc. It should exist in the current process's memory map and
    // then in the ld.so.cache.
    let libc_path = resolve_attach_path("libc", Some(pid.try_into().unwrap())).unwrap();

nit: have mercy on the eyes.

let pid = pid.try_into().unwrap();
let libc_path = resolve_attach_path("libc", Some(pid)).unwrap();

---

test/integration-test/src/tests/load.rs line 432 at r2 (raw file):

#[test]
fn pin_lifecycle_uprobe() {
    const INITIAL_PIN_PATH: &str = "/sys/fs/bpf/aya-uprobe-test-prog";

how about FIRST and a "-1" suffix for symmetry?

[ajwerner]

Reviewable status: 0 of 3 files reviewed, 7 unresolved discussions (waiting on @tamird)

---

-- commits line 6 at r1:

Previously, tamird (Tamir Duberstein) wrote…

"in anticipation"

Done.

---

-- commits line 13 at r2:

Previously, tamird (Tamir Duberstein) wrote…

"isn't part of" is an odd wording. Isn't referenced from?

Done.

---

-- commits line 17 at r2:

Previously, tamird (Tamir Duberstein) wrote…

how could that oddity be addressed? the bit about the absolute path? i think there's a nicer way to phrase what this commit does or does not do.

Done.

---

.github/workflows/ci.yml line 231 at r2 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

seems unrelated

Done.

---

aya/src/programs/uprobe.rs line 126 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

this commentary may be better placed inside the body; it describes the implementation rather than the contract.

Done.

---

aya/src/programs/uprobe.rs line 166 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

we should compile this test always, but only run it on linux-gnu.

#[cfg_attr(not(all(target_os = "linux", target_env = "gnu")), ignore = "something descriptive goes here"]

Done.

---

aya/src/programs/uprobe.rs line 174 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

nit: have mercy on the eyes.

let pid = pid.try_into().unwrap();
let libc_path = resolve_attach_path("libc", Some(pid)).unwrap();

Done.

---

test/integration-test/src/tests/load.rs line 432 at r2 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

how about FIRST and a "-1" suffix for symmetry?

Done.

[tamird]

Reviewed 3 of 3 files at r3, 2 of 2 files at r4, 3 of 3 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ajwerner)

---

aya/src/programs/uprobe.rs line 166 at r1 (raw file):

Previously, ajwerner wrote…

Done.

you missed the "not". maybe put miri first: any(miri, not(all(...)))

[ajwerner]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @tamird)

---

aya/src/programs/uprobe.rs line 133 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

there are several unnecessary conversions and allocations happening here. I realize you're just moving code around, so feel free to disregard.

#718

---

aya/src/programs/uprobe.rs line 166 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

you missed the "not". maybe put miri first: any(miri, not(all(...)))

Done.

[mergify]

@ajwerner, this pull request is now in conflict and requires a rebase.

[tamird]

FYI this overlaps with #719 some, but I think we should land it to unblock VM testing.

Reviewed 2 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ajwerner)

[tamird]

Reviewed 2 of 2 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ajwerner)