Improve AF_XDP test #846
Open
Improve AF_XDP test #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tuetuopay
reviewed
Nov 13, 2024
| // Check whether incoming packet's queue ID matches the queue ID of the socket in XSKMAP at index `queue_id`. | ||
| if SOCKS.get(queue_id) == Some(queue_id) { | ||
| // Queue ID matches, redirect to AF_XDP socket. | ||
| SOCKS.redirect(0, 0).unwrap_or(xdp_action::XDP_ABORTED) |
There was a problem hiding this comment.
shouldn't this be SOCKS.redirect(queue_id, 0)? The test will still work as veth only has one queue, but since we're after correctness, this feels like it's missing.
There was a problem hiding this comment.
Good point, I changed it accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assume_init_mut()on uninitialized memory causes UB. By usingzeroed()the memory is guaranteed to be zero and with that is properly initialized foru8.This change is