-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DenoiseDat.m needs proper testing #11
Comments
Can you show some examples of SWRs and opto pulses distortion? |
I've heard from @lkaraba, @heathlarsson, and @amymarple that it has negatively affected their signal or removed spikes during opto pulses, so maybe they have examples. However, it would have been good to test how this function affects these things before it was made default. |
Yes for opto the noise removal will lose units. Needs to be fully tested. |
Can you please give explicit examples/sessions? What exactly happens there? We need to see the problem to solve it, it would be related to component selection. |
Yes, we should try to fix this. It can be super useful and save a lot of
manual curation time
…On Thu, Oct 31, 2024 at 6:18 PM YY535 ***@***.***> wrote:
Can you please give explicit examples/sessions? What exactly happens
there? We need to see the problem to solve it, it would be related to
component selection.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHSQQZKD2PRVTSE4CWDMGDZ6KUDXAVCNFSM6AAAAABQ6SMVWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQHEYTSNZSGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Some other thoughts on this function.
|
Additionally, a very important point is that the denoising is preformed across the entire recording session and not just high emg intervals. |
Thanks Ryan. Why would this change waveforms in this way? It seems that
waveform themselves are changed, is that the case?
…On Sat, Nov 2, 2024 at 12:51 PM Ryan Harvey ***@***.***> wrote:
Example on how DenoiseDat alters raw signal. The first image is original,
and the second is following DenoiseDat. Because average waveform extraction
is preformed on this altered signal, sessions that used this function may
likely have inaccurate cell trilateration.
image.png (view on web)
<https://github.com/user-attachments/assets/d9bc3215-f542-49ba-ba65-aa8a8891f813>
image.png (view on web)
<https://github.com/user-attachments/assets/332427fc-5157-40d7-a505-c592c56b6380>
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHSQQZ7XTVS5OD7IP7KR6DZ6T7IJAVCNFSM6AAAAABQ6SMVWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGA2DMMBUGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
DenoiseDat was pushed to run by default f69a1ac back in Feb. but was never fully tested. It was removed from default in commit d8acfaf .
There has been reports that it removes spikes and distorts signal during common instances such as SWRs and opto pulses. Without full testing, it's hard to know how this function could affect your signal.
The text was updated successfully, but these errors were encountered: