Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dap-dlv): add args support #545

Merged
merged 2 commits into from
Mar 1, 2023
Merged

feat(dap-dlv): add args support #545

merged 2 commits into from
Mar 1, 2023

Conversation

fioncat
Copy link
Contributor

@fioncat fioncat commented Feb 28, 2023

Sometimes we need to debug programe with args, and now dap-dlv is missing a debugger that supports input args.

According to nvim-dap#620, we can input args dynamically by vim.fn.input.

This is well tested in my mahine with the latest dap.nvim.

Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn't seem out of the ordinary. cc @CharlesChiuGit when you have bandwidth.

Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥝

@Jint-lzxy Jint-lzxy merged commit 71c5a24 into ayamir:main Mar 1, 2023
@CharlesChiuGit
Copy link
Collaborator

LGTM. Doesn't seem out of the ordinary. cc @CharlesChiuGit when you have bandwidth.

Sorry for didn't respond. Got quite busy least few days lol.

boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request Mar 8, 2023
* feat(dap-dlv): add args support

* style(dap-dlv): use vim builtin to split args

(cherry picked from commit 71c5a24)
YanTree pushed a commit to YanTree/nvim that referenced this pull request Apr 9, 2023
* feat(dap-dlv): add args support

* style(dap-dlv): use vim builtin to split args
This was referenced Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants