Skip to content

Remove PowerShell 2.0 Compatibility References #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aybouzaglou merged 2 commits into from
Oct 24, 2025
Merged

Remove PowerShell 2.0 Compatibility References #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48c7713
Update PowerShell compatibility from 2.0 to 5.0+
claude Oct 24, 2025
5dad00f
Update FocusedDebloat PowerShell version requirement to 5.0+
claude Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Applications/ScanSnapHome.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ System.String - Progress messages and status information
Version: 2.0.0
Author: Enhanced for Datto RMM Function Library
Component Category: Applications (Software Deployment)
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment

Datto RMM Applications Exit Codes:
- 0: Success (installation or update completed)
Expand Down
2 changes: 1 addition & 1 deletion components/Scripts/FocusedDebloat.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Category=Applications ; Level=Medium(3) ; Timeout=900s ; Build=1.1.0
.INPUTS
customwhitelist(String) ; skipwindows(Boolean) ; skiphp(Boolean) ; skipdell(Boolean) ; skiplenovo(Boolean)
.REQUIRES
LocalSystem ; PSVersion >=2.0
LocalSystem ; PSVersion >=5.0
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The script's .REQUIRES directive now specifies PSVersion >= 5.0. Ensure that all functions and cmdlets used in this script are compatible with PowerShell 5.0 and later. Verify that no functionality is lost due to the removal of PowerShell 2.0 compatibility.

Consider adding a comment explaining why PowerShell 5.0 is now required, highlighting any specific features or cmdlets used that necessitate this version.

.PARAMETER customwhitelist
Optional array of app names to preserve during removal
.OUTPUTS
Expand Down
2 changes: 1 addition & 1 deletion shared-functions/Core/RMMLogging.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides consistent logging functions with structured output formats optimized f
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
#>

# Global counters for tracking script execution metrics
Expand Down
2 changes: 1 addition & 1 deletion shared-functions/Core/RMMSoftwareDetection.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides fast, reliable software detection methods optimized for Datto RMM envir
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
Avoids: Win32_Product WMI class (causes MSI repair)
#>

Expand Down
2 changes: 1 addition & 1 deletion shared-functions/Core/RMMValidation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides validation functions for Datto RMM environment variables, parameters, a
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
#>

function Get-RMMVariable {
Expand Down
4 changes: 2 additions & 2 deletions shared-functions/Utilities/FileOperations.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Provides file and directory utility functions optimized for Datto RMM environmen
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
#>

function New-RMMDirectory {
Expand Down Expand Up @@ -272,7 +272,7 @@ function Expand-RMMArchive {

switch ($ArchiveType) {
'ZIP' {
# Use .NET Framework for ZIP extraction (PowerShell 2.0 compatible)
# Use .NET Framework for ZIP extraction (PowerShell 5.0+ compatible)
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment indicates that .NET Framework is used for ZIP extraction and is PowerShell 5.0+ compatible. However, the code itself doesn't seem to have changed. If the underlying implementation relies on PowerShell 5.0+ features, this change is correct. Otherwise, it might be misleading.

Suggestion: Double-check if the .NET Framework usage truly necessitates PowerShell 5.0+ and update the comment accordingly. If not, revert the comment to reflect the actual compatibility.

Add-Type -AssemblyName System.IO.Compression.FileSystem
[System.IO.Compression.ZipFile]::ExtractToDirectory($ArchivePath, $DestinationPath)
Comment on lines +275 to 277
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment indicates that .NET Framework is used for ZIP extraction and is PowerShell 5.0+ compatible. This comment should accurately reflect the current compatibility requirement. If the code relies on features specific to PowerShell 5.0 or later for ZIP extraction, this comment is appropriate. Otherwise, consider rephrasing to avoid confusion.

Suggestion: Verify if the .NET Framework usage indeed requires PowerShell 5.0+ and adjust the comment accordingly.

}
Expand Down
2 changes: 1 addition & 1 deletion shared-functions/Utilities/NetworkUtils.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides network-related utility functions optimized for Datto RMM environment:
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
#>

function Set-RMMSecurityProtocol {
Expand Down
2 changes: 1 addition & 1 deletion shared-functions/Utilities/RegistryHelpers.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Provides registry utility functions optimized for Datto RMM environment:
.NOTES
Version: 3.0.0
Author: Datto RMM Function Library
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
#>

function Get-RMMRegistryValue {
Expand Down
4 changes: 2 additions & 2 deletions templates/SelfContainedApplication-Template.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Features:
- Comprehensive error handling and logging
- File attachment support for installers
- Registry-based software detection
- PowerShell 2.0+ compatible
- PowerShell 5.0+ compatible
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The template is now marked as PowerShell 5.0+ compatible. Ensure that all embedded functions and example code within this template are indeed compatible with PowerShell 5.0 and later. Verify that no functionality is lost due to the removal of PowerShell 2.0 compatibility.

Suggestion: Add a comment highlighting any specific features or cmdlets used that necessitate PowerShell 5.0+.


.COMPONENT
Category: Applications (Software Deployment)
Expand All @@ -36,7 +36,7 @@ ForceReinstall = false
.NOTES
Version: 1.0.0
Author: Datto RMM Self-Contained Architecture
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
Deployment: DIRECT (paste script content directly into Datto RMM)
#>

Expand Down
4 changes: 2 additions & 2 deletions templates/SelfContainedScript-Template.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Features:
- Comprehensive error handling and logging
- Flexible timeout support
- System state validation
- PowerShell 2.0+ compatible
- PowerShell 5.0+ compatible
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The template is now marked as PowerShell 5.0+ compatible. Ensure that all embedded functions and example code within this template are indeed compatible with PowerShell 5.0 and later. Verify that no functionality is lost due to the removal of PowerShell 2.0 compatibility.

Suggestion: Add a comment highlighting any specific features or cmdlets used that necessitate PowerShell 5.0+.


.COMPONENT
Category: Scripts (General Automation/Maintenance)
Expand All @@ -36,7 +36,7 @@ DryRun = false
.NOTES
Version: 1.0.0
Author: Datto RMM Self-Contained Architecture
Compatible: PowerShell 2.0+, Datto RMM Environment
Compatible: PowerShell 5.0+, Datto RMM Environment
Deployment: DIRECT (paste script content directly into Datto RMM)
#>

Expand Down
Loading