This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Required to declare migrationsPaths with @InputFiles in JooqModelatorTask
4 tasks
ayedo
reviewed
Jun 14, 2020
jooqModelatorRuntime('org.postgresql:postgresql:42.2.14') | ||
jooqModelatorRuntime('org.mariadb.jdbc:mariadb-java-client:2.6.0') | ||
jooqModelatorRuntime('org.postgresql:postgresql:$PG_DRIVER_VERSION') | ||
jooqModelatorRuntime('org.mariadb.jdbc:mariadb-java-client:$MARIADB_DRIVER_VERSION') | ||
} | ||
|
||
""".trimIndent() | ||
|
||
private fun File.asConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool - never occurred to me one could use extension functions for this.
ayedo
reviewed
Jun 14, 2020
|
||
class IntegrationTest { | ||
|
||
private enum class Database( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cleaner. 👍
Thank you very much for your contribution. The code looks good to me :) The tests pass on my machine. I'm looking forward to the cool badges. I will keep an eye on the MariaDb problem. I have one or two things I want to fix in an upcoming release, and I will also look into that problem then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some maintenance tasks:
Obviously, especially the refactoring is opinionated. Please feel free to pick - or revert parts of the commits - as you like.
A few things to consider:
JooqModelatorTask
by annotatingmigrationPaths
with@InputFiles
tabTwo
results in a capitalized java file nameTabtwo.java
. I presume you're using MacOS with a file system that is case-insensitive. On Linux, these tests did not pass. I adjusted the IntegrationTest to look for "Tabtwo". Hopefully this does not break anything on your machine.As to the issues with bumping mariadb. Bumping from 10.2 to 10.3 resulted in a failing test
liquibaseMariaDd()
, with the following error:Looks like this ticket describes the cause: https://liquibase.jira.com/browse/CORE-3457?oldIssueView=true
And MariaDB 10.4 seems to change the way how to authenticate. I did not bother digging into that.