Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

Reasons and goals for Ayo? #7

Closed
kulshekhar opened this issue Aug 23, 2017 · 10 comments
Closed

Reasons and goals for Ayo? #7

kulshekhar opened this issue Aug 23, 2017 · 10 comments

Comments

@kulshekhar
Copy link

kulshekhar commented Aug 23, 2017

Is there a document or an authoritative post that outlines the reasons behind Ayo existing and lists the goals of this project?

Edit: I'm editing this post because I can't add a new one below (or on any other issue)

Take a look at the other (currently 2) issues in the repository, we'd love input!

I've gone through those issues but couldn't get a clear picture. It would be hard to provide any meaningful input without knowing the technical goals of the project.

@varjmes
Copy link

varjmes commented Aug 23, 2017

Is there a document or an authoritative post that outlines the reasons behind Ayo existing and lists the goals of this project?

Not yet. This project was forked yesterday.
Take a look at the other (currently 2) issues in the repository, we'd love input!

@varjmes
Copy link

varjmes commented Aug 23, 2017

Hey @kulshekhar, sorry you can't create any issues right now. No-one apart from org members can, but tomorrow, everyone will be able to post issues again.

I've gone through those issues but couldn't get a clear picture. It would be hard to provide any meaningful input without knowing the technical goals of the project.

Absolutely, I agree. There is no centralisation of information about what is currently happening in Node core, and I'm not the person to write it. But, speaking for myself, I am interested in Ayo because I am personally unhappy with the leadership of Node core, and want to see if someone else can do better.

As the fork has existed for (less than) a day, there really isn't anything to share. I know that's frustrating, but that's where we're at right now.

Right now, what I'm most interested in is thoughts on #2. Obviously, you can't comment right now (sorry, nor can anyone) but tomorrow I'd love to hear any thoughts you have on how Node could be governed differently. Even if Ayo doesn't become a thing, I think it's a valuable discussion to have, because we can suggest these ideas to Node and see what they think.

<3

@zkat
Copy link
Contributor

zkat commented Aug 24, 2017

There is now a PR, #15, with a draft of the values for this project.

@ayojs ayojs deleted a comment from viperidae Aug 24, 2017
@yuu2lee4
Copy link

Bring fiber in core code like fibjs did or merge to it?

@Fishrock123
Copy link
Contributor

@yuu2lee4 maybe you could open a separate issue for that?

@mtimofiiv
Copy link

Right now, what I'm most interested in is thoughts on #2. Obviously, you can't comment right now (sorry, nor can anyone) but tomorrow I'd love to hear any thoughts you have on how Node could be governed differently. Even if Ayo doesn't become a thing, I think it's a valuable discussion to have, because we can suggest these ideas to Node and see what they think.

Understandable, but I can't really comment without knowing what the problem is exactly. The Node.js project has already had a major fork in io.js and I really liked the results at the time.

It's only natural as things settled down that new problems emerge, but I truthfully do not follow the community close enough to know. I guess that would make me a user of Node.js rather than a contributor, and as such, some of the more esoteric issues with governance or community are things I am not really aware of too much.

But I could get behind io.js back in the day because @mikeal and others did a great job of communicating it all to someone like me, who is not involved in the day-to-day stuff and just wants to write great shit with Node.js.

tl;dr +1 on wanting a mission statement on the fork!

@TimothyGu
Copy link
Member

@mtimofiiv Would love it if you could review #15, which is a "mission statement" for this project.

@Fishrock123
Copy link
Contributor

But I could get behind io.js back in the day because @mikeal and others did a great job of communicating it all to someone like me, who is not involved in the day-to-day stuff and just wants to write great shit with Node.js.

I'd like to point out briefly that back in the day we (members of io.js) actually had considerable trouble describing what differentiated ourselves from Node. We ended up just going with "Node plus ES6!" but it was really much more than that. 😉

@mikeal
Copy link
Contributor

mikeal commented Aug 25, 2017 via email

@varjmes
Copy link

varjmes commented Sep 11, 2017

I think we've answered it well, in the form of our values document.

@varjmes varjmes closed this as completed Sep 11, 2017
addaleax pushed a commit that referenced this issue Oct 26, 2017
Currently when running the test without an internet connection there are
two JavaScript test failures and one cctest. The cctest only fails on
Mac as far as I know. (I've only tested using Mac and Linux thus far).

This commit moves the two JavaScript tests to test/internet.

The details for test_inspector_socket_server.cc:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
make[1]: *** [cctest] Segmentation fault: 11
make: *** [test] Error 2

lldb output:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
Process 63058 stopped
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
    frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
libsystem_info.dylib`_gai_simple:
->  0x7fff96d04384 <+87>: movw   (%rdx), %ax
    0x7fff96d04387 <+90>: movw   %ax, -0x2a(%rbp)
    0x7fff96d0438b <+94>: movq   %r13, -0x38(%rbp)
    0x7fff96d0438f <+98>: movq   0x18(%rbp), %rcx

(lldb) bt
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
  * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
    frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo +
179
    frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255
    frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179
    frame #4: 0x00000001017d8888
cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at
getaddrinfo.c:102
    frame #5: 0x00000001017d880e
cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8,
cb=0x0000000000000000, hostname="nodejs.org", service="0",
hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192
    frame #6: 0x000000010171f781
cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658)
+ 801 at inspector_socket_server.cc:398
    frame #7: 0x00000001016ed590
cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0)
+ 288 at test_inspector_socket_server.cc:593

I'm not sure about the exact cause for this but when using a standalone
c program to simulate this it seems like when the ai_flags
`AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc
line 394, the servname (the port in the FailsToBindToNodejsHost test) is
expected to be a numeric port string to avoid looking it up in
/etc/services. When the port is 0 as is it was before this commit the
segment fault occurs but not if it is non-zero.

PR-URL: nodejs/node#16255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Dec 7, 2017
Currently when running the test without an internet connection there are
two JavaScript test failures and one cctest. The cctest only fails on
Mac as far as I know. (I've only tested using Mac and Linux thus far).

This commit moves the two JavaScript tests to test/internet.

The details for test_inspector_socket_server.cc:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
make[1]: *** [cctest] Segmentation fault: 11
make: *** [test] Error 2

lldb output:

[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
Process 63058 stopped
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
    frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
libsystem_info.dylib`_gai_simple:
->  0x7fff96d04384 <+87>: movw   (%rdx), %ax
    0x7fff96d04387 <+90>: movw   %ax, -0x2a(%rbp)
    0x7fff96d0438b <+94>: movq   %r13, -0x38(%rbp)
    0x7fff96d0438f <+98>: movq   0x18(%rbp), %rcx

(lldb) bt
* thread #1: tid = 0x7b175, 0x00007fff96d04384
* libsystem_info.dylib`_gai_simple + 87, queue =
* 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1,
* address=0x0)
  * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87
    frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo +
179
    frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255
    frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179
    frame #4: 0x00000001017d8888
cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at
getaddrinfo.c:102
    frame #5: 0x00000001017d880e
cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8,
cb=0x0000000000000000, hostname="nodejs.org", service="0",
hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192
    frame #6: 0x000000010171f781
cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658)
+ 801 at inspector_socket_server.cc:398
    frame #7: 0x00000001016ed590
cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0)
+ 288 at test_inspector_socket_server.cc:593

I'm not sure about the exact cause for this but when using a standalone
c program to simulate this it seems like when the ai_flags
`AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc
line 394, the servname (the port in the FailsToBindToNodejsHost test) is
expected to be a numeric port string to avoid looking it up in
/etc/services. When the port is 0 as is it was before this commit the
segment fault occurs but not if it is non-zero.

PR-URL: nodejs/node#16255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants