This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
worker: implement MessagePort and MessageChannel
#98
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| 'use strict'; | ||
|
|
||
| const EventEmitter = require('events'); | ||
| const util = require('util'); | ||
|
|
||
| const { MessagePort, MessageChannel } = process.binding('messaging'); | ||
| util.inherits(MessagePort, EventEmitter); | ||
|
|
||
| const debug = util.debuglog('worker'); | ||
|
|
||
| // A MessagePort consists of a handle (that wraps around an | ||
| // uv_async_t) which can receive information from other threads and emits | ||
| // .onmessage events, and a function used for sending data to a MessagePort | ||
| // in some other thread. | ||
| function onmessage(payload, flag) { | ||
| debug(`[${process.threadId}] received message`, flag, payload); | ||
| // Emit the flag and deserialized object to userland. | ||
| if (flag === 0 || flag === undefined) | ||
| this.emit('message', payload); | ||
| else | ||
| this.emit('flaggedMessage', flag, payload); | ||
| } | ||
|
|
||
| Object.defineProperty(MessagePort.prototype, 'onmessage', { | ||
| enumerable: true, | ||
| configurable: true, | ||
| get() { return onmessage; }, | ||
| set(value) { | ||
| Object.defineProperty(this, { | ||
| writable: true, | ||
| enumerable: true, | ||
| configurable: true, | ||
| value | ||
| }); | ||
| this.ref(); | ||
| this.start(); | ||
| } | ||
| }); | ||
|
|
||
| function oninit() { | ||
| setupPortReferencing(this, this, 'message'); | ||
| } | ||
|
|
||
| Object.defineProperty(MessagePort.prototype, 'oninit', { | ||
| enumerable: true, | ||
| writable: false, | ||
| value: oninit | ||
| }); | ||
|
|
||
| function onclose() { | ||
| this.emit('close'); | ||
| } | ||
|
|
||
| Object.defineProperty(MessagePort.prototype, 'onclose', { | ||
| enumerable: true, | ||
| writable: false, | ||
| value: onclose | ||
| }); | ||
|
|
||
| function setupPortReferencing(port, eventEmitter, eventName) { | ||
| // Keep track of whether there are any workerMessage listeners: | ||
| // If there are some, ref() the channel so it keeps the event loop alive. | ||
| // If there are none or all are removed, unref() the channel so the worker | ||
| // can shutdown gracefully. | ||
| port.unref(); | ||
| eventEmitter.on('newListener', (name) => { | ||
| if (name === eventName && eventEmitter.listenerCount(eventName) === 0) { | ||
| port.ref(); | ||
| port.start(); | ||
| } | ||
| }); | ||
| eventEmitter.on('removeListener', (name) => { | ||
| if (name === eventName && eventEmitter.listenerCount(eventName) === 0) { | ||
| port.stop(); | ||
| port.unref(); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| module.exports = { | ||
| MessagePort, | ||
| MessageChannel | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict'; | ||
|
|
||
| const { MessagePort, MessageChannel } = require('internal/worker'); | ||
|
|
||
| module.exports = { MessagePort, MessageChannel }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing
onmessagewill stop themessageandflaggedMessageevents from being emitted. Is that intended behaviour?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would say so. This is only there to match the Web spec more closely, but in that case you don’t want the EventEmitter interface anyways I guess.