Added size adjustment functionality for popup window #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoung19
reviewed
Jan 13, 2025
| @@ -1,5 +1,5 @@ | |||
| html, | |||
| body, | |||
| #__plasmo { | |||
| height: 100%; | |||
| height: "auto"; | |||
There was a problem hiding this comment.
I think this breaks floating mode.
|
Also comments regarding the general approach, it works but to give us the flexibility of allowing the user to manually configure the width and height of the extension in the future can we store the raw height and width values in the settings object as opposed to the label? I would just have a simple string to size mapping object directly in the Settings modal that we can change whenever. |
|
If it's too messy because of how |
Co-authored-by: Andy Young <andyluyoung@gmail.com>
Co-authored-by: Andy Young <andyluyoung@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15