Cloned tabs appear next to clone source

Fix brave#2779
ayumi · Aug 12, 2016 · e4ff6eb · e4ff6eb
1 parent fa1612e
commit e4ff6eb
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 11 deletions.
diff --git a/js/stores/windowStore.js b/js/stores/windowStore.js
@@ -190,16 +190,17 @@ const newFrame = (frameOpts, openInForeground, insertionIndex) => {
 
   // Find the closest index to the current frame's index which has
   // a different ancestor frame key.
-  if (!insertionIndex) {
+  if (insertionIndex === undefined) {
     insertionIndex = FrameStateUtil.findIndexForFrameKey(frames, frameOpts.parentFrameKey)
-  }
-  if (insertionIndex === -1) {
-    insertionIndex = frames.size
-  }
-  while (insertionIndex < frames.size) {
-    ++insertionIndex
-    if (!FrameStateUtil.isAncestorFrameKey(frames, frames.get(insertionIndex), frameOpts.parentFrameKey)) {
-      break
+    if (insertionIndex === -1) {
+      insertionIndex = frames.size
+    } else {
+      while (insertionIndex < frames.size) {
+        ++insertionIndex
+        if (!FrameStateUtil.isAncestorFrameKey(frames, frames.get(insertionIndex), frameOpts.parentFrameKey)) {
+          break
+        }
+      }
     }
   }
   if (FrameStateUtil.isFrameKeyPinned(frames, frameOpts.parentFrameKey)) {
@@ -415,7 +416,8 @@ const doAction = (action) => {
       newFrame(action.frameOpts, action.openInForeground)
       break
     case WindowConstants.WINDOW_CLONE_FRAME:
-      newFrame(FrameStateUtil.cloneFrame(action.frameOpts, action.guestInstanceId), action.openInForeground)
+      let insertionIndex = FrameStateUtil.findIndexForFrameKey(windowState.get('frames'), action.frameOpts.key) + 1
+      newFrame(FrameStateUtil.cloneFrame(action.frameOpts, action.guestInstanceId), action.openInForeground, insertionIndex)
       break
     case WindowConstants.WINDOW_CLOSE_FRAME:
       // Use the frameProps we passed in, or default to the active frame

diff --git a/test/components/frameTest.js b/test/components/frameTest.js
@@ -150,6 +150,47 @@ describe('clone tab', function () {
     })
   })
 
+  describe('index', function () {
+    Brave.beforeAll(this)
+
+    before(function * () {
+      this.clickWithTargetPage = Brave.server.url('click_with_target.html')
+      this.page1 = Brave.server.url('page1.html')
+
+      yield setup(this.app.client)
+      yield this.app.client
+        .waitUntilWindowLoaded()
+        .windowByUrl(Brave.browserWindowUrl)
+        .waitForUrl(Brave.newTabUrl)
+        .url(this.clickWithTargetPage)
+        .waitForVisible('#name')
+        .click('#name')
+      yield this.app.client
+        .windowByUrl(Brave.browserWindowUrl)
+        .waitForExist('.tab[data-frame-key="2"]')
+      yield this.app.client
+        .ipcSend('shortcut-set-active-frame-by-index', 0)
+        .windowByUrl(Brave.browserWindowUrl)
+        .ipcSend(messages.SHORTCUT_ACTIVE_FRAME_CLONE)
+        .waitUntil(function () {
+          return this.getTabCount().then((count) => {
+            return count === 3
+          })
+        })
+    })
+
+    it('inserts after the tab to clone', function * () {
+      this.tab1 = '.tabArea:nth-child(1) .tab[data-frame-key="1"]'
+      this.tab2 = '.tabArea:nth-child(2) .tab[data-frame-key="3"]'
+      this.tab3 = '.tabArea:nth-child(3) .tab[data-frame-key="2"]'
+      yield this.app.client
+        .windowByUrl(Brave.browserWindowUrl)
+        .waitForExist(this.tab1)
+        .waitForExist(this.tab2)
+        .waitForExist(this.tab3)
+    })
+  })
+
   describe('history', function () {
     Brave.beforeAll(this)
 
@@ -283,4 +324,3 @@ function * setup (client) {
     .waitForVisible('#window')
     .waitForVisible(urlInput)
 }
-