Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client…

…_warning_log

In #9 , I added a new EXTERNAL_CLIENT table for supporting Restapi/gnmi control plane acls.
But if dest port is not defined, it will print traceback in syslog.
Avoiding this scenario, we add a default empty list for dst_ports and print a warning log and skip processing EXTERNAL_CLIENT table.

Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com

scripts/caclmgrd

@@ -551,6 +551,8 @@ class ControlPlaneAclManager(daemon_base.DaemonBase):
  ip_protocols = self.ACL_SERVICES[acl_service]["ip_protocols"]
  if "dst_ports" in self.ACL_SERVICES[acl_service]:
  dst_ports = self.ACL_SERVICES[acl_service]["dst_ports"]
+ else:
+ dst_ports = []
 
  acl_rules = {}
 
@@ -604,6 +606,12 @@ class ControlPlaneAclManager(daemon_base.DaemonBase):
  self.log_warning("Unable to determine if ACL table '{}' contains IPv4 or IPv6 rules. Skipping table..."
  .format(table_name))
  continue
+ # If no destination port found for this ACL table,
+ # log a message and skip processing this table.
+ if len(dst_ports) == 0:
+ self.log_warning("Required destination port not found for ACL table '{}'. Skipping table..."
+ .format(table_name))
+ continue
  ipv4_src_ip_set = set()
  ipv6_src_ip_set = set()
  # For each ACL rule in this table (in descending order of priority)