Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 changes #528

Merged
merged 44 commits into from
Aug 11, 2023
Merged

Bootstrap 5 changes #528

merged 44 commits into from
Aug 11, 2023

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Aug 5, 2022 •
edited
Loading

This should be ready for merging into the main (5.x) branch now.

https://getbootstrap.com/docs/5.2/migration/

@joeparsons joeparsons self-assigned this Aug 5, 2022
@mmunro-ltrr
Copy link
Member

The whole migration from Bootstrap 4 to 5 might need a spike or epic approach: I'll make an issue to reference that.

@joeparsons
Copy link
Member Author

The whole migration from Bootstrap 4 to 5 might need a spike or epic approach: I'll make an issue to reference that.

Thanks @mmunro-ltrr!

@mmunro-ltrr
Copy link
Member

That last failure might be a consequence of the file ownership changes the GitHub Actions now do on the checked-out copy of the repository. A quick & dirty fix might be throwing around a sudo or two. We've not exercised all the things that could be affected by the ownership changes.

@mmunro-ltrr mmunro-ltrr linked an issue Aug 8, 2022 that may be closed by this pull request
Bootstrap 4 end of life is the start of 2023; future Arizona Bootstrap development should use Bootstrap 5 #530
Closed
3 tasks
joeparsons
joeparsons commented Aug 9, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
joeparsons
joeparsons commented Aug 9, 2023
View reviewed changes
package.json Show resolved Hide resolved
@joeparsons joeparsons marked this pull request as ready for review August 10, 2023 00:16
@joeparsons joeparsons changed the title (WIP) Bootstrap 5 Bootstrap 5 changes Aug 10, 2023
@joeparsons
Copy link
Member Author

This should be ready for merging into the main (5.x) branch now.

@joeparsons joeparsons added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 10, 2023
This was referenced Aug 10, 2023
Closed
Closed
mmunro-ltrr
mmunro-ltrr approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mmunro-ltrr mmunro-ltrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be inclined to merge this with the main branch asap: it won't be anything like its final state, but a great way to work on getting there.

@mmunro-ltrr mmunro-ltrr merged commit 2b2ea11 into main Aug 11, 2023
2 checks passed
@mmunro-ltrr mmunro-ltrr deleted the twbs5-parsonsj branch August 11, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadean tadean tadean approved these changes

@mmunro-ltrr mmunro-ltrr mmunro-ltrr approved these changes

@trackleft trackleft trackleft approved these changes

Assignees

@joeparsons joeparsons

@trackleft trackleft

@mmunro-ltrr mmunro-ltrr

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap 4 end of life is the start of 2023; future Arizona Bootstrap development should use Bootstrap 5
4 participants
@joeparsons @mmunro-ltrr @trackleft @tadean