Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3820 Full-width paragraphs have a different width in the Content region compared to other regions #3859

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Nov 4, 2024

Description

This PR adjusts the styling of full-width regions and paragraphs to:

  • Remove the extra right margin from full-width content in regions besides the Content region
  • Adjust the position of divs with the content class in all regions so that they align vertically with content divs in the Content region.

As part of this PR, some styling is moved from modules/custom/az_paragraphs/css/az_paragraphs_full_width.css to themes/custom/az_barrio/css/style.css since it applies to paragraphs in other regions which may display as full width even when they do not have the "Full width" checkbox checked. For example, the az-full-width-row class is included in the view display for all Text on Media paragraphs, so the styling for that class should be available wherever those paragraphs can be used.

Questions:

  1. Should this be a patch release "bug fix" or a minor release "visual change"?
    • (Nov 15, 2024) We are leaning towards including this in a minor release due to allow for further testing of these visual changes.

Release notes

Related issues

How to test

Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3859.probo.build
Test page: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3859.probo.build/brian-test-page

Compare various arrangements of standard and full-width Text with Background and Text on Media paragraphs.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz added bug Something isn't working visual change Introduces a visual change labels Nov 4, 2024
@bberndt-uaz bberndt-uaz self-assigned this Nov 4, 2024
@bberndt-uaz bberndt-uaz marked this pull request as ready for review November 12, 2024 22:23
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner November 12, 2024 22:23
@bberndt-uaz
Copy link
Contributor Author

@trackleft found that this PR can cause a horizontal scrollbar to be displayed when full-width paragraphs are present. Reverting to draft to work on this further.

@bberndt-uaz bberndt-uaz marked this pull request as draft November 18, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visual change Introduces a visual change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full-width paragraphs have a different width in the Content region compared to other regions
1 participant