add multiarch Docker support via buildx #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbscarel-bl Hi. Apologies for the such a late response. Can you please re-open the PR? I would like to merge it |
|
I mistakenly clicked on submitting a PR, I was actually just making local
changes for myself. In any case, you can see the changes made here
master...fbscarel-bl:stubby4j:master
It's a bit hacky as I didn't worry too much about making it sufficiently
generic for an audience that was not myself, but it does work. I've
published multiarch images here at that point in time:
https://hub.docker.com/r/fbscarelbl/stubby4j/tags
Cheers!
…On Tue, Jan 16, 2024 at 3:03 PM Alexander Zagniotov < ***@***.***> wrote:
@fbscarel-bl <https://github.com/fbscarel-bl> Hi. Apologies for the such
a late response. Can you please re-open the PR? I would like to merge it
—
Reply to this email directly, view it on GitHub
<#462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDT77JDYNBJQGW7TLRI3MMTYO26GDAVCNFSM6AAAAAA7YHAIGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGI2DINRQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I achieved some progress with publishing multiple arch images, see the latest-jre11: https://hub.docker.com/layers/azagniotov/stubby4j/latest-jre11/images/sha256-22a50332f75497b65a876ed245aefedda736c4e0b09dff81d389cc661240f0ca?context=explore But, please do not use. I need to clean up the PR first: #465 |
|
The project that uses stubby4j on my company is on JDK 17, which is why I
"ported" your script to that. Seemed to work well.
To be honest the image has been working fine so far, but thanks for the
update. The buildx stuff is really powerful.
…On Tue, Jan 16, 2024 at 10:20 PM Alexander Zagniotov < ***@***.***> wrote:
I achieved some progress with publishing multiple arch images, see the
latest-jre11:
https://hub.docker.com/layers/azagniotov/stubby4j/latest-jre11/images/sha256-22a50332f75497b65a876ed245aefedda736c4e0b09dff81d389cc661240f0ca?context=explore
But, please do not use. I need to clean up the PR first: #465
<#465>
—
Reply to this email directly, view it on GitHub
<#462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDT77JBANZR7L7IVEMHEN63YO4RMFAVCNFSM6AAAAAA7YHAIGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUG44DAMJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I will add JDK 17 image too now, by reusing your PR state |
|
@fbscarel-bl Just as FYI, the JRE 17 is up: https://hub.docker.com/r/azagniotov/stubby4j/tags Would you be able to sanity check the ARM 64 image? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.