Bump MacOS CMake target to MacOS 13 #320
Conversation
The minimum required MacOS version for Lime3DS was already MacOS 13 due to dependencies, but until now the compilation target was set to MacOS 11
OpenSauce04
force-pushed
the
macos-13-cmake-target
branch
from
59c7a82 to
305b67a
Compare
|
Unsure why this is failing specifically on x86_64. I'm not entirely sure what changing the MacOS target version actually does, so I'll have to do a bit of research on this later. The error isn't particularly helpful. |
|
I'm not sure why it fails when the OSX version is bumped up, but it's an issue with Zydis that's since been fixed. See zyantific/zydis#350 and zyantific/zydis#474. So the answer is to update the Zydis dependency used in the dynarmic version that Lime3DS uses. You could also use or fork my master branch; I keep the dependencies somewhat up-to-date: https://github.com/rtiangha/dynarmic Or fork PabloMK7's branch and manually update Zydis (since I can't remember if I had to make changes on the Citra side to play nicely with some of the newer dependencies either; it was a while ago). |
|
Seeing as you're already putting in the work, I don't see any reason not to use yours. |
|
I'm testing it now with the Lime3DS codebase. When it's done compiling, I'll post the results. I think it should work with the master branch with no mods on this end; if not, I'll figure out why and how to fix (I can't remember if I ran into issues with Xbyak or fmt conflicts that required a minor cmake change to bump up or set a policy or two). |
|
Looks like it worked. https://github.com/rtiangha/Lime3DS/actions/runs/10188175631/job/28183784346 I'll submit a seperate dependency PR without the OSX change since I noticed that SDL also got an update (better gamepad support, from what I can glean from the commit log) so might as well get that one in too. |
|
oop looks like github picked up on the "Close #xxx" keyword 🙃 |
|
Successfully tested on my end |
No description provided.