Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve folder structure #425

Merged
merged 3 commits into from
Dec 21, 2024
Merged

refactor: improve folder structure #425

merged 3 commits into from
Dec 21, 2024

Conversation

azat-io
Copy link
Owner

@azat-io azat-io commented Dec 20, 2024

Description

Updated the project file structure.

Additional context

#417.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • Read contribution guidelines.

@azat-io
Copy link
Owner Author

azat-io commented Dec 20, 2024

Everything is currently working correctly except for one test in:
test/rules/sort-imports/read-closest-ts-config-by-path.test.ts

@azat-io
Copy link
Owner Author

azat-io commented Dec 20, 2024

@hugop95
Copy link
Contributor

hugop95 commented Dec 20, 2024

@azat-io PR for the test can be found here: #426.

@azat-io
Copy link
Owner Author

azat-io commented Dec 20, 2024

@hugop95 Nice, thank you!

Ready for review.

@azat-io azat-io marked this pull request as ready for review December 20, 2024 17:47
Copy link
Contributor

@hugop95 hugop95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azat-io 👍 All good!

[suggestion] What do you think about creating an index.ts file in the utils folder?

@azat-io
Copy link
Owner Author

azat-io commented Dec 20, 2024

@hugop95 I don't have a clear opinion on this. There are no index.ts files in the utilities folders for rules (rules/sort-array-includes/), it seems logical to me that there is no index.ts in utils.

@hugop95
Copy link
Contributor

hugop95 commented Dec 20, 2024

@azat-io There is one in types, which is why I was asking 🙂. No big difference for me.

@azat-io
Copy link
Owner Author

azat-io commented Dec 20, 2024

Or we could remove index.ts from types/

@hugop95
Copy link
Contributor

hugop95 commented Dec 20, 2024

@azat-io

Or we could remove index.ts from types/

Fine by me as well 👍

@azat-io
Copy link
Owner Author

azat-io commented Dec 21, 2024

Done!

@azat-io azat-io merged commit 4dd2e1b into main Dec 21, 2024
8 checks passed
@azat-io azat-io deleted the refactor/structure branch December 21, 2024 00:52
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1649bea) to head (f81a6b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        77    +1     
  Lines         7639      7646    +7     
  Branches      1634      1634           
=========================================
+ Hits          7639      7646    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants