-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve folder structure #425
Conversation
Everything is currently working correctly except for one test in: |
eba4394
to
25b40f7
Compare
@hugop95 Nice, thank you! Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azat-io 👍 All good!
[suggestion] What do you think about creating an index.ts
file in the utils
folder?
@hugop95 I don't have a clear opinion on this. There are no |
@azat-io There is one in |
Or we could remove |
Fine by me as well 👍 |
1ce8baf
to
f81a6b3
Compare
Done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 76 77 +1
Lines 7639 7646 +7
Branches 1634 1634
=========================================
+ Hits 7639 7646 +7 ☔ View full report in Codecov by Sentry. |
Description
Updated the project file structure.
Additional context
#417.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).